Turned on performance-unnecessary-value-param everywhere.

Author: gaaclarke

.clang-tidy

@@ -28,7 +28,8 @@ clang-analyzer-*,\
 readability-identifier-naming,\
 clang-diagnostic-*,\
 google-objc-*,\
-google-explicit-constructor"
+google-explicit-constructor,\
+performance-unnecessary-value-param"
 
 CheckOptions:
   - key:    modernize-use-default-member-init.UseAssignment

ci/lint.sh

@@ -34,8 +34,9 @@ DART_BIN="${SRC_DIR}/third_party/dart/tools/sdks/dart-sdk/bin"
 DART="${DART_BIN}/dart"
 # TODO(https://github.com/flutter/flutter/issues/113848): Migrate all platforms
 # to have this as an error.
-MAC_HOST_WARNINGS_AS_ERRORS="performance-move-const-arg,performance-unnecessary-value-param"
+MAC_HOST_WARNINGS_AS_ERRORS="performance-move-const-arg"
 
+FLUTTER_LINT_PRINT_FIX=1
 # FLUTTER_LINT_PRINT_FIX will make it so that fix is executed and the generated
 # diff is printed to stdout if clang-tidy fails. This is helpful for enabling
 # new lints.

fml/platform/android/jni_weak_ref.cc

@@ -54,12 +54,14 @@ ScopedJavaLocalRef<jobject> GetRealObject(JNIEnv* env, jweak obj) {
 }
 
 void JavaObjectWeakGlobalRef::Assign(const JavaObjectWeakGlobalRef& other) {
-  if (&other == this)
+  if (&other == this) {
     return;
+  }
 
   JNIEnv* env = AttachCurrentThread();
-  if (obj_)
+  if (obj_) {
     env->DeleteWeakGlobalRef(obj_);
+  }
 
   obj_ = other.obj_ ? env->NewWeakGlobalRef(other.obj_) : NULL;
 }

impeller/renderer/backend/vulkan/command_buffer_vk.cc

@@ -4,6 +4,8 @@
 
 #include "impeller/renderer/backend/vulkan/command_buffer_vk.h"
 
+#include <utility>
+
 #include "flutter/fml/logging.h"
 #include "impeller/base/validation.h"
 #include "impeller/renderer/backend/vulkan/context_vk.h"
@@ -15,7 +17,7 @@
 namespace impeller {
 
 std::shared_ptr<CommandBufferVK> CommandBufferVK::Create(
-    std::weak_ptr<const Context> context,
+    const std::weak_ptr<const Context>& context,
     vk::Device device,
     vk::CommandPool command_pool,
     SurfaceProducerVK* surface_producer) {
@@ -41,7 +43,7 @@ CommandBufferVK::CommandBufferVK(std::weak_ptr<const Context> context,
                                  SurfaceProducerVK* surface_producer,
                                  vk::CommandPool command_pool,
                                  vk::UniqueCommandBuffer command_buffer)
-    : CommandBuffer(context),
+    : CommandBuffer(std::move(context)),
       device_(device),
       command_pool_(command_pool),
       command_buffer_(std::move(command_buffer)),

impeller/renderer/backend/vulkan/command_buffer_vk.h

@@ -14,7 +14,7 @@ namespace impeller {
 class CommandBufferVK final : public CommandBuffer {
  public:
   static std::shared_ptr<CommandBufferVK> Create(
-      std::weak_ptr<const Context> context,
+      const std::weak_ptr<const Context>& context,
       vk::Device device,
       vk::CommandPool command_pool,
       SurfaceProducerVK* surface_producer);

impeller/renderer/backend/vulkan/device_buffer_vk.cc

@@ -39,7 +39,7 @@ DeviceBufferVK::DeviceBufferVK(
     DeviceBufferDescriptor desc,
     ContextVK& context,
     std::unique_ptr<DeviceBufferAllocationVK> device_allocation)
-    : DeviceBuffer(std::move(desc)),
+    : DeviceBuffer(desc),
       context_(context),
       device_allocation_(std::move(device_allocation)) {}
 

impeller/renderer/backend/vulkan/pipeline_vk.cc

@@ -40,9 +40,9 @@ vk::DescriptorSetLayout PipelineCreateInfoVK::GetDescriptorSetLayout() const {
 }
 
 PipelineVK::PipelineVK(std::weak_ptr<PipelineLibrary> library,
-                       PipelineDescriptor desc,
+                       const PipelineDescriptor& desc,
                        std::unique_ptr<PipelineCreateInfoVK> create_info)
-    : Pipeline(std::move(library), std::move(desc)),
+    : Pipeline(std::move(library), desc),
       pipeline_info_(std::move(create_info)) {}
 
 PipelineVK::~PipelineVK() = default;

impeller/renderer/backend/vulkan/pipeline_vk.h

@@ -43,7 +43,7 @@ class PipelineVK final
       public BackendCast<PipelineVK, Pipeline<PipelineDescriptor>> {
  public:
   PipelineVK(std::weak_ptr<PipelineLibrary> library,
-             PipelineDescriptor desc,
+             const PipelineDescriptor& desc,
              std::unique_ptr<PipelineCreateInfoVK> create_info);
 
   // |Pipeline|

impeller/renderer/backend/vulkan/surface_producer_vk.cc

@@ -5,6 +5,7 @@
 #include "impeller/renderer/backend/vulkan/surface_producer_vk.h"
 
 #include <array>
+#include <utility>
 
 #include "impeller/base/validation.h"
 #include "impeller/renderer/backend/vulkan/surface_vk.h"
@@ -13,7 +14,7 @@
 namespace impeller {
 
 std::unique_ptr<SurfaceProducerVK> SurfaceProducerVK::Create(
-    std::weak_ptr<Context> context,
+    const std::weak_ptr<Context>& context,
     const SurfaceProducerCreateInfoVK& create_info) {
   auto surface_producer =
       std::make_unique<SurfaceProducerVK>(context, create_info);
@@ -28,7 +29,7 @@ std::unique_ptr<SurfaceProducerVK> SurfaceProducerVK::Create(
 SurfaceProducerVK::SurfaceProducerVK(
     std::weak_ptr<Context> context,
     const SurfaceProducerCreateInfoVK& create_info)
-    : context_(context), create_info_(create_info) {}
+    : context_(std::move(context)), create_info_(create_info) {}
 
 SurfaceProducerVK::~SurfaceProducerVK() = default;
 

impeller/renderer/backend/vulkan/surface_producer_vk.h

@@ -33,7 +33,7 @@ class SurfaceSyncObjectsVK {
 class SurfaceProducerVK {
  public:
   static std::unique_ptr<SurfaceProducerVK> Create(
-      std::weak_ptr<Context> context,
+      const std::weak_ptr<Context>& context,
       const SurfaceProducerCreateInfoVK& create_info);
 
   SurfaceProducerVK(std::weak_ptr<Context> context,