Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 0a1923e

Browse files
csmartdalton86Skia Commit-Bot
authored andcommitted
Disable QCOM_tiled_rendering while we wait for test devices
There are devices that advertise this extension but don't actually provide the GL entrypoints. This is causing live crashes. Bug: flutter:47164 Bug: flutter:47804 Change-Id: Idded47e8dbd4462463ad91a62b06b0df3245f0c1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263809 Reviewed-by: Brian Osman <[email protected]> Commit-Queue: Chris Dalton <[email protected]>
1 parent a3a704a commit 0a1923e

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

src/gpu/gl/GrGLCaps.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,9 +697,11 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,
697697
fSamplerObjectSupport = version >= GR_GL_VER(2,0);
698698
}
699699

700-
if (GR_IS_GR_GL_ES(standard)) {
701-
fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
702-
}
700+
// https://github.com/flutter/flutter/issues/47164
701+
// https://github.com/flutter/flutter/issues/47804
702+
// if (GR_IS_GR_GL_ES(standard)) {
703+
// fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
704+
// }
703705

704706
FormatWorkarounds formatWorkarounds;
705707

src/gpu/gl/GrGLInterfaceAutogen.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,7 @@ bool GrGLInterface::validate() const {
351351

352352
if ((GR_IS_GR_GL_ES(fStandard) && (
353353
fExtensions.has("GL_QCOM_tiled_rendering")))) {
354-
if (!fFunctions.fEndTiling ||
355-
!fFunctions.fStartTiling) {
356-
RETURN_FALSE_INTERFACE;
357-
}
354+
// all functions were marked optional or test_only
358355
}
359356

360357
if ((GR_IS_GR_GL(fStandard) && (

tools/gpu/gl/interface/interface.json5

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,11 @@
300300

301301
"functions": [
302302
"StartTiling", "EndTiling",
303+
],
304+
// https://github.com/flutter/flutter/issues/47164
305+
// https://github.com/flutter/flutter/issues/47804
306+
"optional": [
307+
"StartTiling", "EndTiling",
303308
]
304309
},
305310

0 commit comments

Comments
 (0)