Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 04e7781

Browse files
rmistrySkia Commit-Bot
authored andcommitted
Revert "Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers"
This reverts commit 8115853. Reason for revert: Hopefully not needed after https://skia-review.googlesource.com/c/skia/+/262217 Original change's description: > Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers > > Without this the task was getting deduped with tasks that ran days ago. > Eg: https://chromium-swarm.appspot.com/task?d=true&id=496142b461f15f10 > > Bug: skia:9514 > Change-Id: I1c93e3f298ef5d6be222578618759b5fb63ca8c1 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261555 > Reviewed-by: Ravi Mistry <[email protected]> > Commit-Queue: Ravi Mistry <[email protected]> [email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:9514 Change-Id: I90d2d5b52394b791dc744e12c149b31c64af3027 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263198 Reviewed-by: Ravi Mistry <[email protected]> Reviewed-by: Eric Boren <[email protected]> Commit-Queue: Ravi Mistry <[email protected]>
1 parent a4c4c3c commit 04e7781

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

infra/bots/gen_tasks_logic/gen_tasks_logic.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -819,13 +819,6 @@ func (b *builder) buildTaskDrivers() string {
819819
CipdPackages: append(specs.CIPD_PKGS_GIT, b.MustGetCipdPackageFromAsset("go")),
820820
Command: []string{
821821
"/bin/bash", "skia/infra/bots/build_task_drivers.sh", specs.PLACEHOLDER_ISOLATED_OUTDIR,
822-
// The following arguments are not used by the script but are specified
823-
// because they prevent de-duplication.
824-
specs.PLACEHOLDER_REPO,
825-
specs.PLACEHOLDER_REVISION,
826-
specs.PLACEHOLDER_ISSUE,
827-
specs.PLACEHOLDER_PATCHSET,
828-
specs.PLACEHOLDER_CODEREVIEW_SERVER,
829822
},
830823
Dimensions: b.linuxGceDimensions(MACHINE_TYPE_SMALL),
831824
EnvPrefixes: map[string][]string{

infra/bots/tasks.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13944,12 +13944,7 @@
1394413944
"command": [
1394513945
"/bin/bash",
1394613946
"skia/infra/bots/build_task_drivers.sh",
13947-
"${ISOLATED_OUTDIR}",
13948-
"<(REPO)",
13949-
"<(REVISION)",
13950-
"<(ISSUE)",
13951-
"<(PATCHSET)",
13952-
"<(CODEREVIEW_SERVER)"
13947+
"${ISOLATED_OUTDIR}"
1395313948
],
1395413949
"dimensions": [
1395513950
"cpu:x86-64-Haswell_GCE",

0 commit comments

Comments
 (0)