Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 0393687

Browse files
Mike KleinSkia Commit-Bot
authored andcommitted
flip on a bunch of GCC warnings
I've landed fixes for most of these, leaving -Wclass-memaccess as a TODO. Bug: skia:9674 Change-Id: Ifb951bc66e022b48ff4b66e4555d3fe3c7ef5aaf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257501 Reviewed-by: Ben Wagner aka dogben <[email protected]> Commit-Queue: Mike Klein <[email protected]>
1 parent e74c776 commit 0393687

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

gn/BUILD.gn

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -351,16 +351,12 @@ config("warnings") {
351351
"-Wnon-virtual-dtor",
352352
"-Wno-noexcept-type",
353353

354-
# TODO(dogben): The following are new between GCC 6 (stretch) and GCC 8 (buster); they should
355-
# all be investigated.
356-
"-Wno-array-bounds",
354+
# GCC 8+ bundles a number of fundamentally different warnings under this same flag,
355+
# ranging from false positive (only copying a prefix of SkRRect from serialized form)
356+
# to possibly useful (memcpy() with non-trivial types). Annoyingly you can't really
357+
# break them up any finer.
358+
# TODO(mtklein): suppress / fix each site as appropriate?
357359
"-Wno-class-memaccess",
358-
"-Wno-stringop-overflow",
359-
"-Wno-restrict",
360-
"-Wno-stringop-truncation",
361-
"-Wno-sizeof-pointer-memaccess",
362-
"-Wno-parentheses",
363-
"-Wno-format-truncation",
364360
]
365361
}
366362

0 commit comments

Comments
 (0)