Skip to content

Commit f4ed2b4

Browse files
committed
Remove hardcoded useWasm: false for expectedBenchmarkMetrics()
1 parent 8d85c20 commit f4ed2b4

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

packages/devtools_app/benchmark/devtools_benchmarks_test.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,7 @@ Future<void> _runBenchmarks({bool useWasm = false}) async {
7575

7676
for (final devToolsBenchmark in DevToolsBenchmark.values) {
7777
final benchmarkName = devToolsBenchmark.id;
78-
// Note: Due to https://github.com/flutter/flutter/pull/175392 there is no
79-
// longer any difference in benchmark events for skwasm vs. canvaskit.
80-
//
81-
// TODO(https://github.com/flutter/flutter/issues/177057): Remove hardcoded
82-
// useWasm: false param when package:web_benchmarks is updated.
83-
final expectedMetrics = expectedBenchmarkMetrics(useWasm: false);
78+
final expectedMetrics = expectedBenchmarkMetrics();
8479
const expectedComputations = BenchmarkMetricComputation.values;
8580
final scores = taskResult.scores[benchmarkName] ?? [];
8681
expect(

packages/devtools_app/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ dev_dependencies:
7676
stager: ^1.3.0
7777
stream_channel: ^2.1.1
7878
test: ^1.21.0
79-
web_benchmarks: ^4.0.0
79+
web_benchmarks: ^4.1.0
8080
webkit_inspection_protocol: ">=0.5.0 <2.0.0"
8181

8282
flutter:

0 commit comments

Comments
 (0)