fix(logger): Change formatter that collides with new libp2p version [fixes DXJ-459] #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2023 21:47
akim-bow
changed the title
akim-bow
changed the title
shamsartem
reviewed
Aug 29, 2023
| @@ -380,7 +380,7 @@ export abstract class FluencePeer { | |||
| // Otherwise the race might occur corrupting the prevData | |||
|
|
|||
| log_particle.debug('id %s. sending particle to interpreter', item.particle.id); | |||
| log_particle.trace('id %s. prevData: %a', item.particle.id, prevData); | |||
| log_particle.trace('id %s. prevData: %s', item.particle.id, new TextDecoder().decode(prevData)); | |||
There was a problem hiding this comment.
I suggest moving this part to a separate function, instead of dublicating this TextDecoder().decode() stuff so when Ivan creates binary data for avm we can change one line instead of changing three or pottentially more
There was a problem hiding this comment.
Refactored this to private method
added 2 commits
August 29, 2023 23:06
folex
approved these changes
Aug 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.