This repository was archived by the owner on Jul 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Cleaning up technical debts #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXJ-328 Make max number of streams configurable
See this: https://fluencelabs.slack.com/archives/C8FDH536W/p1677833893040599 And also search for TODO comment in JS Client repo DXJ-219 Fix hanging jest test for ephemeral networks DXJ-148 Improve wording and add explanations in error `'No handler has been registered for serviceId ...'`
Right now, error states something like
One user righteously asked:
And it is a great question because that word "handler" we do not use anywhere. This error should be reworded, and explanations on possible solutions/investigations given. |
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
reviewed
Apr 3, 2023
shamsartem
approved these changes
Apr 3, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: DXJ-328, DXJ-219, DXJ-148