Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

feat: Cleaning up technical debts #295

Merged
merged 34 commits into from
Apr 3, 2023
Merged

feat: Cleaning up technical debts #295

merged 34 commits into from
Apr 3, 2023

Conversation

coder11
Copy link
Contributor

@coder11 coder11 commented Mar 31, 2023

Closes: DXJ-328, DXJ-219, DXJ-148

@linear
Copy link

linear bot commented Mar 31, 2023

DXJ-328 Make max number of streams configurable

See this: https://fluencelabs.slack.com/archives/C8FDH536W/p1677833893040599

And also search for TODO comment in JS Client repo

DXJ-219 Fix hanging jest test for ephemeral networks

DXJ-148 Improve wording and add explanations in error `'No handler has been registered for serviceId ...'`

Right now, error states something like

Local service error, ret_code is 1, error message is '"No handler has been registered for serviceId='onboardingservice' fnName='get_location_game'

One user righteously asked:

what does it mean by handler?

And it is a great question because that word "handler" we do not use anywhere.

This error should be reworded, and explanations on possible solutions/investigations given.

@coder11 coder11 marked this pull request as ready for review April 3, 2023 01:30
@coder11 coder11 requested a review from shamsartem April 3, 2023 01:30
@coder11 coder11 requested a review from shamsartem April 3, 2023 17:02
@coder11 coder11 merged commit 0b2f12d into master Apr 3, 2023
@coder11 coder11 deleted the farewell branch April 3, 2023 17:52
@fluencebot fluencebot mentioned this pull request Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants