This repository was archived by the owner on Jul 10, 2025. It is now read-only.
feat(logs): Use debug.js library for logging [DXJ-327]
#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coder11
changed the title
debug.js library for logging [DXJ-327]
DXJ-118 FluenceJS debug logging improvements
These should be absolutely forbidden for the eternity:
I'd also recommend enabling timestamps in logs and having some log formatting like eg aqua has: DXJ-71 Use 'debug' for logging in FluenceJS
Swap logLevel for debug for the following reasons:
Do not forget to update logging in marine-js Don't forget to mention that "verbose" should be turned on for logs to work in browser |
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
| export const registerService: RegisterService = ({ peer, def, serviceId, service }) => { | ||
| log.debug('registering aqua service %o', { def, serviceId, service }); |
There was a problem hiding this comment.
maybe add a log that service was registered successfully? not sure
folex
reviewed
Mar 10, 2023
| @@ -134,37 +136,41 @@ export class RelayConnection extends FluenceConnection { | |||
|
|
|||
| async connect(onIncomingParticle: ParticleHandler) { | |||
There was a problem hiding this comment.
is it possible to add log that connection succeeded?
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
| item.particle.logTo('debug', 'sending particle:'); | ||
| this.connection?.sendParticle(item.nextPeerIds, item.particle.toString()).then( | ||
| () => { | ||
| log.trace('id %s. sending particle into network', item.particle.id); |
There was a problem hiding this comment.
Suggested change
| log.trace('id %s. sending particle into network', item.particle.id); | |
| log.trace('id %s. sending particle to relay', item.particle.id); |
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
| @@ -226,7 +227,7 @@ export class EphemeralNetwork { | |||
| } | |||
|
|
|||
| private async _send(from: PeerIdB58, to: PeerIdB58[], particle: string) { | |||
| log.info(`Sending particle from ${from}, to ${JSON.stringify(to)}`); | |||
| log.trace(`Sending particle from %s, to %j`, from, to); | |||
folex
reviewed
Mar 10, 2023
folex
reviewed
Mar 10, 2023
folex
approved these changes
Mar 10, 2023
shamsartem
reviewed
Mar 10, 2023
| const hello = await helloTest(); | ||
| console.log('hello test finished, result: ', hello); | ||
|
|
||
| // TODO: some wired error shit about SharedArrayBuffer |
There was a problem hiding this comment.
is there a task for that? just so we don't forget
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: DXJ-327, DXJ-118, DXJ-71