This repository was archived by the owner on Jul 10, 2025. It is now read-only.
feat!: Expose updated JS Client API via js-client.api package
#246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move marine-related part into FJS repo (DXJ184) 2. Move towards component-oriented architecture (DXJ183) 3. Different JS Client distros for node.js and web (DXJ185)
coder11
changed the title
js-client.api package
coder11
requested review from
nahsi and
shamsartem
and removed request for
nahsi
shamsartem
reviewed
Feb 14, 2023
| @@ -67,6 +43,7 @@ export const callFunction = async (rawFnArgs: Array<any>, def: FunctionCallDef, | |||
| * Convenience function to support Aqua `service` generation backend | |||
| * The compiler only need to generate a call the function and provide the corresponding definitions and the air script | |||
| * | |||
| (seq | |||
shamsartem
reviewed
Feb 14, 2023
packages/client/api/src/util.ts
Outdated
| */ | ||
| export const getDefaultPeer = (): Promise<IFluenceClient> => { | ||
| return new Promise((resolve, reject) => { | ||
| let interval: NodeJS.Timer | undefined; |
There was a problem hiding this comment.
if it's for frontend that would be a number not NodeJS.Timer. Doesn't reallty affect anything right here but it's more of an issue in general that types should be from Browser environment
There was a problem hiding this comment.
I've decided to remove it whatsoever and added a comment explaining why I don't want to risk any non-necessary types to appear in API
shamsartem
reviewed
Feb 14, 2023
packages/client/api/src/util.ts
Outdated
| export const getDefaultPeer = (): Promise<IFluenceClient> => { | ||
| return new Promise((resolve, reject) => { | ||
| let interval: NodeJS.Timer | undefined; | ||
| let hits = 50; |
There was a problem hiding this comment.
seems arbitrary. What it depends on? Do you think each lib user will have roughly the same requirements ceiling of 5 seconds loading time?
There was a problem hiding this comment.
I've added a couple of comments
shamsartem
approved these changes
Feb 14, 2023
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.