Skip to content

fix: remove _filter_zeroes #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2023
Merged

fix: remove _filter_zeroes #139

merged 2 commits into from
Jan 7, 2023

Conversation

fjosw
Copy link
Owner

@fjosw fjosw commented Jan 6, 2023

This PR removes the filtering of idls in derived_observable.

Closes #138

@fjosw fjosw requested a review from s-kuberski January 6, 2023 12:43
@s-kuberski
Copy link
Collaborator

This looks good. Do you want to delete the function entirely or should we maybe put it in a separate function, e.g., in misc?

@fjosw
Copy link
Owner Author

fjosw commented Jan 7, 2023

I think copying over this function to misc alone wouldn't add functionality, we would need a function that takes an Obs as an argument and returns a filtered Obs. I don't have a use case for such a function in mind but feel free to add it.

@fjosw fjosw merged commit aec74a1 into develop Jan 7, 2023
@fjosw fjosw deleted the fix/remove_filter_zeroes branch January 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with _filter_zeroes and Corr
2 participants