feat: mongo schema changes (#493)

Author: fityannugroho

prisma/mongodb/schema.prisma

@@ -8,8 +8,7 @@ datasource db {
 }
 
 model District {
-  id          String    @id @default(auto()) @map("_id") @db.ObjectId
-  code        String    @unique
+  code        String    @id @map("_id")
   name        String
   regencyCode String    @map("regency_code")
   regency     Regency   @relation(fields: [regencyCode], references: [code])
@@ -19,8 +18,7 @@ model District {
 }
 
 model Island {
-  id               String   @id @default(auto()) @map("_id") @db.ObjectId
-  code             String   @unique
+  code             String   @id @map("_id")
   coordinate       String
   isOutermostSmall Boolean  @map("is_outermost_small")
   isPopulated      Boolean  @map("is_populated")
@@ -32,17 +30,15 @@ model Island {
 }
 
 model Province {
-  id        String    @id @default(auto()) @map("_id") @db.ObjectId
-  code      String    @unique
+  code      String @id @map("_id")
   name      String
   regencies Regency[]
 
   @@map("provinces")
 }
 
 model Regency {
-  id           String     @id @default(auto()) @map("_id") @db.ObjectId
-  code         String     @unique
+  code         String     @id @map("_id")
   name         String
   provinceCode String     @map("province_code")
   islands      Island[]
@@ -61,8 +57,7 @@ model SeederLogs {
 }
 
 model Village {
-  id           String   @id @default(auto()) @map("_id") @db.ObjectId
-  code         String   @unique
+  code         String   @id @map("_id")
   districtCode String   @map("district_code")
   name         String
   district     District @relation(fields: [districtCode], references: [code])

src/district/district.service.spec.ts

@@ -183,7 +183,6 @@ describe('DistrictService', () => {
         .spyOn(prismaService.district, 'findUnique')
         .mockResolvedValue({
           ...expectedDistrict,
-          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
           // @ts-expect-error
           regency: {
             ...expectedRegency,

src/island/island.service.spec.ts

@@ -235,7 +235,6 @@ describe('IslandService', () => {
         .spyOn(prismaService.island, 'findUnique')
         .mockResolvedValue({
           ...expectedIsland,
-          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
           // @ts-expect-error
           regency: { ...expectedRegency, province: expectedProvince },
         });
@@ -268,7 +267,6 @@ describe('IslandService', () => {
         .spyOn(prismaService.island, 'findUnique')
         .mockResolvedValue({
           ...expectedIsland,
-          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
           // @ts-expect-error
           regency: null,
         });

src/regency/regency.service.spec.ts

@@ -161,7 +161,6 @@ describe('RegencyService', () => {
         .spyOn(prismaService.regency, 'findUnique')
         .mockReturnValue({
           ...expectedRegency,
-          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
           // @ts-expect-error
           province: expectedProvince,
         });

src/village/village.service.spec.ts

@@ -194,7 +194,6 @@ describe('VillageService', () => {
         .spyOn(prismaService.village, 'findUnique')
         .mockResolvedValue({
           ...expectedVillage,
-          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
           // @ts-expect-error
           district: {
             ...expectedDistrict,

test/district.e2e-spec.ts

@@ -5,7 +5,7 @@ import {
   provinceRegex,
   regencyRegex,
 } from './helper/data-regex';
-import { expectIdFromMongo, getEncodedSymbols } from './helper/utils';
+import { getEncodedSymbols } from './helper/utils';
 
 describe('District (e2e)', () => {
   const baseUrl = '/districts';
@@ -23,13 +23,11 @@ describe('District (e2e)', () => {
       const districts = await tester.expectData<District[]>(baseUrl);
 
       for (const district of districts) {
-        expect(district).toEqual(
-          expectIdFromMongo({
-            code: expect.stringMatching(districtRegex.code),
-            name: expect.stringMatching(districtRegex.name),
-            regencyCode: district.code.slice(0, 4),
-          }),
-        );
+        expect(district).toEqual({
+          code: expect.stringMatching(districtRegex.code),
+          name: expect.stringMatching(districtRegex.name),
+          regencyCode: district.code.slice(0, 4),
+        });
       }
     });
 
@@ -66,13 +64,11 @@ describe('District (e2e)', () => {
       );
 
       for (const district of districts) {
-        expect(district).toEqual(
-          expectIdFromMongo({
-            code: expect.stringMatching(districtRegex.code),
-            name: expect.stringMatching(new RegExp(testName, 'i')),
-            regencyCode: district.code.slice(0, 4),
-          }),
-        );
+        expect(district).toEqual({
+          code: expect.stringMatching(districtRegex.code),
+          name: expect.stringMatching(new RegExp(testName, 'i')),
+          regencyCode: district.code.slice(0, 4),
+        });
       }
     });
 
@@ -83,13 +79,11 @@ describe('District (e2e)', () => {
       );
 
       for (const district of districts) {
-        expect(district).toEqual(
-          expectIdFromMongo({
-            code: expect.stringMatching(districtRegex.code),
-            name: expect.stringMatching(districtRegex.name),
-            regencyCode,
-          }),
-        );
+        expect(district).toEqual({
+          code: expect.stringMatching(districtRegex.code),
+          name: expect.stringMatching(districtRegex.name),
+          regencyCode,
+        });
       }
     });
   });
@@ -111,24 +105,22 @@ describe('District (e2e)', () => {
         `${baseUrl}/${testCode}`,
       );
 
-      expect(district).toEqual(
-        expectIdFromMongo({
-          code: testCode,
-          name: expect.stringMatching(districtRegex.name),
-          regencyCode: testCode.slice(0, 4),
-          parent: {
-            regency: expectIdFromMongo({
-              code: testCode.slice(0, 4),
-              name: expect.stringMatching(regencyRegex.name),
-              provinceCode: testCode.slice(0, 2),
-            }),
-            province: expectIdFromMongo({
-              code: testCode.slice(0, 2),
-              name: expect.stringMatching(provinceRegex.name),
-            }),
+      expect(district).toEqual({
+        code: testCode,
+        name: expect.stringMatching(districtRegex.name),
+        regencyCode: testCode.slice(0, 4),
+        parent: {
+          regency: {
+            code: testCode.slice(0, 4),
+            name: expect.stringMatching(regencyRegex.name),
+            provinceCode: testCode.slice(0, 2),
           },
-        }),
-      );
+          province: {
+            code: testCode.slice(0, 2),
+            name: expect.stringMatching(provinceRegex.name),
+          },
+        },
+      });
     });
   });
 

test/helper/data-regex.ts

@@ -4,33 +4,33 @@ type DataRegex<T extends Record<string | number | symbol, unknown>> = Partial<
   Record<keyof T, RegExp>
 >;
 
-export const provinceRegex: DataRegex<Province> = {
+export const provinceRegex = {
   code: /^\d{2}$/,
   name: /^(?!\s)(?!PROVINSI)[A-Z ]+$/,
-};
+} as const satisfies DataRegex<Province>;
 
-export const regencyRegex: DataRegex<Regency> = {
+export const regencyRegex = {
   code: /^\d{4}$/,
   name: /^(?:KABUPATEN|KOTA)[A-Z ]+$/,
   provinceCode: provinceRegex.code,
-};
+} as const satisfies DataRegex<Regency>;
 
-export const districtRegex: DataRegex<District> = {
+export const districtRegex = {
   code: /^\d{6}$/,
   name: /^[a-zA-Z0-9\-'.\\/() ]+$/,
   regencyCode: regencyRegex.code,
-};
+} as const satisfies DataRegex<District>;
 
-export const villageRegex: DataRegex<Village> = {
+export const villageRegex = {
   code: /^\d{10}$/,
   name: /^[a-zA-Z0-9\-'"’.*\\/() ]+$/,
   districtCode: districtRegex.code,
-};
+} as const satisfies DataRegex<Village>;
 
-export const islandRegex: DataRegex<Island> = {
+export const islandRegex = {
   code: /^\d{9}$/,
   name: /^[a-zA-Z0-9\-'/ ]+$/,
   coordinate:
     /^([0-8][0-9]|90)°([0-5][0-9]|60)'(([0-5][0-9].[0-9]{2})|60.00)"\s(N|S)\s(0\d{2}|1([0-7][0-9]|80))°([0-5][0-9]|60)'(([0-5][0-9].[0-9]{2})|60.00)"\s(E|W)$/,
   regencyCode: /^\d{4}|$/,
-};
+} as const satisfies DataRegex<Island>;

test/helper/utils.ts

@@ -1,5 +1,3 @@
-import { isDBProvider } from '@/common/utils/db/provider';
-
 /**
  * All symbol characters.
  */
@@ -26,15 +24,3 @@ export function getEncodedSymbols(
     .filter((char) => !exclude.includes(char))
     .map((char) => encodeURIComponent(char));
 }
-
-/**
- * Expect the data contains the `id` property if the database provider is MongoDB.
- */
-export function expectIdFromMongo(data: Record<keyof any, any>) {
-  return {
-    ...data,
-    id: isDBProvider('mongodb')
-      ? expect.stringMatching(/^[0-9a-fA-F]{24}$/)
-      : undefined,
-  };
-}