Skip to content

Commit 8114fcb

Browse files
chore: update windows types to match latest
1 parent bb5d282 commit 8114fcb

File tree

2 files changed

+23
-25
lines changed

2 files changed

+23
-25
lines changed

packages/firebase_core/firebase_core/windows/firebase_core_plugin.cpp

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ FirebaseCorePlugin::FirebaseCorePlugin() {}
5151

5252
FirebaseCorePlugin::~FirebaseCorePlugin() = default;
5353

54-
// Convert a Pigeon FirebaseOptions to a Firebase Options.
55-
firebase::AppOptions PigeonFirebaseOptionsToAppOptions(
56-
const PigeonFirebaseOptions &pigeon_options) {
54+
// Convert a CoreFirebaseOptions to a Firebase Options.
55+
firebase::AppOptions CoreFirebaseOptionsToAppOptions(
56+
const CoreFirebaseOptions &pigeon_options) {
5757
firebase::AppOptions options;
5858
options.set_api_key(pigeon_options.api_key().c_str());
5959
options.set_app_id(pigeon_options.app_id().c_str());
@@ -73,21 +73,19 @@ firebase::AppOptions PigeonFirebaseOptionsToAppOptions(
7373
return options;
7474
}
7575

76-
// Convert a AppOptions to PigeonInitializeOption
77-
PigeonFirebaseOptions optionsFromFIROptions(
76+
// Convert a AppOptions to CoreFirebaseOptions
77+
CoreFirebaseOptions optionsFromFIROptions(
7878
const firebase::AppOptions &options) {
79-
PigeonFirebaseOptions pigeon_options = PigeonFirebaseOptions();
80-
pigeon_options.set_api_key(options.api_key());
81-
pigeon_options.set_app_id(options.app_id());
79+
CoreFirebaseOptions pigeon_options = CoreFirebaseOptions(
80+
options.api_key(), options.app_id(), options.messaging_sender_id(),
81+
options.project_id());
8282
// AppOptions initialises as empty char so we check to stop empty string to
8383
// Flutter Same for storage bucket below
8484
const char *db_url = options.database_url();
8585
if (db_url != nullptr && db_url[0] != '\0') {
8686
pigeon_options.set_database_u_r_l(db_url);
8787
}
8888
pigeon_options.set_tracking_id(nullptr);
89-
pigeon_options.set_messaging_sender_id(options.messaging_sender_id());
90-
pigeon_options.set_project_id(options.project_id());
9189

9290
const char *storage_bucket = options.storage_bucket();
9391
if (storage_bucket != nullptr && storage_bucket[0] != '\0') {
@@ -96,34 +94,34 @@ PigeonFirebaseOptions optionsFromFIROptions(
9694
return pigeon_options;
9795
}
9896

99-
// Convert a firebase::App to PigeonInitializeResponse
100-
PigeonInitializeResponse AppToPigeonInitializeResponse(const App &app) {
101-
PigeonInitializeResponse response = PigeonInitializeResponse();
102-
response.set_name(app.name());
103-
response.set_options(optionsFromFIROptions(app.options()));
97+
// Convert a firebase::App to CoreInitializeResponse
98+
CoreInitializeResponse AppToCoreInitializeResponse(const App &app) {
99+
flutter::EncodableMap plugin_constants;
100+
CoreInitializeResponse response = CoreInitializeResponse(
101+
app.name(), optionsFromFIROptions(app.options()), plugin_constants);
104102
return response;
105103
}
106104

107105
void FirebaseCorePlugin::InitializeApp(
108106
const std::string &app_name,
109-
const PigeonFirebaseOptions &initialize_app_request,
110-
std::function<void(ErrorOr<PigeonInitializeResponse> reply)> result) {
107+
const CoreFirebaseOptions &initialize_app_request,
108+
std::function<void(ErrorOr<CoreInitializeResponse> reply)> result) {
111109
// Create an app
112110
App *app =
113-
App::Create(PigeonFirebaseOptionsToAppOptions(initialize_app_request),
111+
App::Create(CoreFirebaseOptionsToAppOptions(initialize_app_request),
114112
app_name.c_str());
115113

116114
// Send back the result to Flutter
117-
result(AppToPigeonInitializeResponse(*app));
115+
result(AppToCoreInitializeResponse(*app));
118116
}
119117

120118
void FirebaseCorePlugin::InitializeCore(
121119
std::function<void(ErrorOr<flutter::EncodableList> reply)> result) {
122120
// TODO: Missing function to get the list of currently initialized apps
123-
std::vector<PigeonInitializeResponse> initializedApps;
121+
std::vector<CoreInitializeResponse> initializedApps;
124122
std::vector<App *> all_apps = App::GetApps();
125123
for (const App *app : all_apps) {
126-
initializedApps.push_back(AppToPigeonInitializeResponse(*app));
124+
initializedApps.push_back(AppToCoreInitializeResponse(*app));
127125
}
128126

129127
flutter::EncodableList encodableList;
@@ -135,7 +133,7 @@ void FirebaseCorePlugin::InitializeCore(
135133
}
136134

137135
void FirebaseCorePlugin::OptionsFromResource(
138-
std::function<void(ErrorOr<PigeonFirebaseOptions> reply)> result) {}
136+
std::function<void(ErrorOr<CoreFirebaseOptions> reply)> result) {}
139137

140138
void FirebaseCorePlugin::SetAutomaticDataCollectionEnabled(
141139
const std::string &app_name, bool enabled,

packages/firebase_core/firebase_core/windows/firebase_core_plugin.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ class FirebaseCorePlugin : public flutter::Plugin,
3434
// FirebaseCoreHostApi
3535
virtual void InitializeApp(
3636
const std::string &app_name,
37-
const PigeonFirebaseOptions &initialize_app_request,
38-
std::function<void(ErrorOr<PigeonInitializeResponse> reply)> result)
37+
const CoreFirebaseOptions &initialize_app_request,
38+
std::function<void(ErrorOr<CoreInitializeResponse> reply)> result)
3939
override;
4040
virtual void InitializeCore(
4141
std::function<void(ErrorOr<flutter::EncodableList> reply)> result)
4242
override;
4343
virtual void OptionsFromResource(
44-
std::function<void(ErrorOr<PigeonFirebaseOptions> reply)> result)
44+
std::function<void(ErrorOr<CoreFirebaseOptions> reply)> result)
4545
override;
4646

4747
// FirebaseAppHostApi

0 commit comments

Comments
 (0)