Skip to content

Commit 367257d

Browse files
committed
Merge remote-tracking branch 'origin/master' into flutter/plugins#1942
2 parents 5c6815b + 0e1d2fa commit 367257d

File tree

4 files changed

+9
-19
lines changed

4 files changed

+9
-19
lines changed

packages/firebase_admob/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
1-
## 0.9.0+6
1+
## 0.9.0+7
22

33
* Update Android gradle plugin, gradle, and Admob versions.
44
* Improvements to the Android implementation, fixing warnings about a possible null pointer exception.
5+
* Fixed an issue where an advertisement could incorrectly remain displayed when transitioning to another screen.
6+
7+
## 0.9.0+6
8+
9+
* Remove duplicate example from documentation.
510

611
## 0.9.0+5
712

packages/firebase_admob/README.md

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -129,21 +129,6 @@ myBanner
129129
);
130130
```
131131

132-
Ads must be loaded before they're shown.
133-
```dart
134-
myBanner
135-
// typically this happens well before the ad is shown
136-
..load()
137-
..show(
138-
// Positions the banner ad 60 pixels from the bottom of the screen
139-
anchorOffset: 60.0,
140-
// Positions the banner ad 10 pixels from the center of the screen to the left
141-
horizontalCenterOffset: -10.0,
142-
// Banner Position
143-
anchorType: AnchorType.bottom,
144-
);
145-
```
146-
147132
```dart
148133
myInterstitial
149134
..load()

packages/firebase_admob/android/src/main/java/io/flutter/plugins/firebaseadmob/MobileAd.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,11 @@ void show() {
179179
void dispose() {
180180
super.dispose();
181181

182+
adView.destroy();
183+
182184
View contentView = activity.findViewById(id);
183185
if (contentView == null || !(contentView.getParent() instanceof ViewGroup)) return;
184186

185-
adView.destroy();
186-
187187
ViewGroup contentParent = (ViewGroup) (contentView.getParent());
188188
contentParent.removeView(contentView);
189189
}

packages/firebase_admob/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase AdMob, supporting
33
banner, interstitial (full-screen), and rewarded video ads
44
author: Flutter Team <[email protected]>
55
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_admob
6-
version: 0.9.0+6
6+
version: 0.9.0+7
77

88
flutter:
99
plugin:

0 commit comments

Comments
 (0)