Skip to content

Fix build script when NDK_ROOT is set #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2023
Merged

Fix build script when NDK_ROOT is set #1203

merged 1 commit into from
Feb 24, 2023

Conversation

chkuang-g
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

When NDK_ROOT is set, this script would still set it to /tmp/android-ndk-r21e, which does not normally contains NDK unless NDK_ROOT is NOT set and install_prereqs.sh is called before.

Fix that line so that the if statement would properly exit when NDK_ROOT is set.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Ran locally.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@chkuang-g
Fix build script when NDK_ROOT is set
2dad6a7 
When `NDK_ROOT` is set, this script would still set it to
`/tmp/android-ndk-r21e`, which does not normally contains NDK unless
`NDK_ROOT` is NOT set and `install_prereqs.sh` is called before.

Fix that line so that the if statement would properly exit when
`NDK_ROOT` is set.
@chkuang-g chkuang-g added the skip-release-notes Skip release notes check label Feb 9, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Feb 9, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @chkuang-g on commit 1be7d24
Last updated: Thu Feb 23 19:31 PST 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [2/3 os: macos windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [FLAKINESS] [Android] [2/3 os: macos windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 9, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 9, 2023
@chkuang-g chkuang-g merged commit 1be7d24 into main Feb 24, 2023
@chkuang-g chkuang-g deleted the patch/android-build-script branch February 24, 2023 00:42
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 24, 2023
chkuang-g added a commit that referenced this pull request Feb 24, 2023
@chkuang-g
Fix build script when NDK_ROOT is set (#1203)
3300253 
When `NDK_ROOT` is set, this script would still set it to
`/tmp/android-ndk-r21e`, which does not normally contains NDK unless
`NDK_ROOT` is NOT set and `install_prereqs.sh` is called before.

Fix that line so that the if statement would properly exit when
`NDK_ROOT` is set.
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2023
@firebase firebase locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chkuang-g @jonsimantov @a-maurice