Skip to content

Commit bc562cd

Browse files
authored
Merge a9231f3 into 6bf9316
2 parents 6bf9316 + a9231f3 commit bc562cd

File tree

8 files changed

+368
-404
lines changed

8 files changed

+368
-404
lines changed

gma/integration_test/AndroidManifest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@
2323
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
2424
<uses-permission android:name="android.permission.WAKE_LOCK" />
2525
<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="28" />
26-
<application android:label="@string/app_name">
26+
<application android:label="@string/app_name"
27+
android:taskAffinity="">
2728
<!-- You may replace the sample App ID below with your own App ID. -->
2829
<meta-data
2930
android:name="com.google.android.gms.ads.APPLICATION_ID"
3031
android:value="ca-app-pub-3940256099942544~3347511713"/>
3132
<activity android:name="android.app.NativeActivity"
33+
android:exported="true"
3234
android:screenOrientation="portrait"
3335
android:configChanges="orientation|screenSize">
3436
<meta-data android:name="android.app.lib_name"

gma/src_java/com/google/firebase/gma/internal/cpp/AdInspectorHelper.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,8 @@
1616

1717
package com.google.firebase.gma.internal.cpp;
1818

19-
import android.util.Log;
2019
import com.google.android.gms.ads.AdError;
2120
import com.google.android.gms.ads.AdInspectorError;
22-
import com.google.android.gms.ads.MobileAds;
2321
import com.google.android.gms.ads.OnAdInspectorClosedListener;
2422

2523
/** Helper class for listening to AdInspector closed events. */
@@ -28,17 +26,17 @@ public final class AdInspectorHelper implements OnAdInspectorClosedListener {
2826
* Pointer to the C++ AdInspectorClosedListener object to invoke when the AdInspector has been
2927
* closed.
3028
*/
31-
private long mNativeCallbackPtr;
29+
private final long nativeCallbackPtr;
3230

3331
/** Constructor. */
3432
AdInspectorHelper(long nativeCallbackPtr) {
35-
mNativeCallbackPtr = nativeCallbackPtr;
33+
this.nativeCallbackPtr = nativeCallbackPtr;
3634
}
3735

3836
/** Method that the Android GMA SDK invokes when the AdInspector has been closed. */
3937
@Override
4038
public void onAdInspectorClosed(AdInspectorError error) {
41-
adInspectorClosedCallback(mNativeCallbackPtr, error);
39+
adInspectorClosedCallback(nativeCallbackPtr, error);
4240
}
4341

4442
/**

gma/src_java/com/google/firebase/gma/internal/cpp/AdRequestHelper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.firebase.gma.internal.cpp;
1818

19+
import androidx.annotation.Nullable;
1920
import java.util.Calendar;
2021
import java.util.Date;
2122

@@ -35,6 +36,7 @@ public AdRequestHelper() {}
3536
* @param day The day to use in creating the Date object
3637
* @return A Date object with the appropriate date
3738
*/
39+
@Nullable
3840
public Date createDate(int year, int month, int day) {
3941
try {
4042
Calendar cal = Calendar.getInstance();

0 commit comments

Comments
 (0)