Skip to content

Commit 0d779c4

Browse files
Googlera-maurice
authored andcommitted
Delete unused (and invalid) overload of Promise::RegisterForTask().
The method is "invalid" because, when instantiated, it fails to compile (the `RegisterForTask` overload that it calls does not exist). This was never noticed because this type of compilation error is not detected until the method is actually invoked, forcing the compiler to instantiate it. Since the method was never invoked, nobody noticed. PiperOrigin-RevId: 347404402
1 parent d435dd2 commit 0d779c4

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

firestore/src/android/promise_android.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,6 @@ class Promise {
5454
Promise(Promise&& other) = default;
5555
Promise& operator=(Promise&& other) = default;
5656

57-
void RegisterForTask(FnEnumType op, const jni::Object& task) {
58-
return RegisterForTask(op, task.get());
59-
}
60-
6157
void RegisterForTask(jni::Env& env, FnEnumType op, const jni::Object& task) {
6258
handle_ = completer_->Alloc(static_cast<int>(op));
6359

0 commit comments

Comments
 (0)