Skip to content

Commit c4df596

Browse files
authored
Merge pull request #126 from morganchen12/builds
continue to build static targets for now
2 parents 4ff8237 + bfb6316 commit c4df596

File tree

11 files changed

+572
-60
lines changed

11 files changed

+572
-60
lines changed

FirebaseAuthUI/FIRAuthPickerViewController.xib

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2-
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="10117" systemVersion="15G31" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES">
2+
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="10117" systemVersion="15G1004" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES">
33
<dependencies>
44
<deployment identifier="iOS"/>
55
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="10085"/>

FirebaseAuthUI/FirebaseAuthUI.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ FOUNDATION_EXPORT double FirebaseAuthUIVersionNumber;
2222
//! Project version string for FirebaseAuthUI.
2323
FOUNDATION_EXPORT const unsigned char FirebaseAuthUIVersionString[];
2424

25-
#import <FIRAuthPickerViewController.h>
26-
#import <FIRAuthProviderUI.h>
27-
#import <FIRAuthUI.h>
28-
#import <FIRAuthUIBaseViewController.h>
29-
#import <FIRAuthUIErrorUtils.h>
25+
#import <FirebaseAuthUI/FIRAuthPickerViewController.h>
26+
#import <FirebaseAuthUI/FIRAuthProviderUI.h>
27+
#import <FirebaseAuthUI/FIRAuthUI.h>
28+
#import <FirebaseAuthUI/FIRAuthUIBaseViewController.h>
29+
#import <FirebaseAuthUI/FIRAuthUIErrorUtils.h>
3030

FirebaseFacebookAuthUI/FIRFacebookAuthUI.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17-
#import <FIRAuthUI.h>
17+
#import <FirebaseAuthUI/FIRAuthUI.h>
1818

1919
NS_ASSUME_NONNULL_BEGIN
2020

FirebaseFacebookAuthUI/FIRFacebookAuthUI.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#import <FirebaseAuth/FIRUserInfo.h>
2121
#import <FBSDKCoreKit/FBSDKCoreKit.h>
2222
#import <FBSDKLoginKit/FBSDKLoginKit.h>
23-
#import <FIRAuthUIErrorUtils.h>
23+
#import <FirebaseAuthUI/FIRAuthUIErrorUtils.h>
2424

2525
/** @var kBundleFileName
2626
@brief The name of the bundle containing Facebook auth provider assets/resources.

FirebaseGoogleAuthUI/FIRGoogleAuthUI.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17-
#import <FIRAuthUI.h>
17+
#import <FirebaseAuthUI/FIRAuthUI.h>
1818

1919
NS_ASSUME_NONNULL_BEGIN
2020

FirebaseGoogleAuthUI/FIRGoogleAuthUI.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#import <GoogleSignIn/GoogleSignIn.h>
2020
#import <FirebaseAuth/FIRGoogleAuthProvider.h>
2121
#import <FirebaseAuth/FIRUserInfo.h>
22-
#import <FIRAuthUIErrorUtils.h>
22+
#import <FirebaseAuthUI/FIRAuthUIErrorUtils.h>
2323

2424
/** @var kGoogleGamesScope
2525
@brief The OAuth scope string for the "Games" scope.

FirebaseUI.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
Pod::Spec.new do |s|
22
s.name = 'FirebaseUI'
3-
s.version = '0.5.3'
3+
s.version = '0.5.4'
44
s.summary = 'UI binding libraries for Firebase.'
55
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
66
s.license = { :type => 'Apache 2.0', :file => 'FirebaseUIFrameworks/LICENSE' }
77
s.author = 'Firebase'
8-
s.source = { :http => 'https://github.com/firebase/FirebaseUI-iOS/releases/download/0.5.3/FirebaseUIFrameworks.zip' }
8+
s.source = { :http => 'https://github.com/firebase/FirebaseUI-iOS/releases/download/0.5.4/FirebaseUIFrameworks.zip' }
99
s.platform = :ios
10-
s.ios.deployment_target = '8.0'
10+
s.ios.deployment_target = '7.0'
1111
s.ios.framework = 'UIKit'
1212
s.requires_arc = true
1313
s.default_subspecs = 'All'

FirebaseUI.xcodeproj/project.pbxproj

Lines changed: 499 additions & 2 deletions
Large diffs are not rendered by default.

Podfile

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,24 @@ target 'FirebaseGoogleAuthUI' do
5151
end
5252
end
5353

54+
target 'Database' do
55+
# Pods for Database
56+
pod 'Firebase/Database'
57+
end
58+
59+
target 'Auth' do
60+
# Pods for Auth
61+
pod 'Firebase/Auth'
62+
end
63+
64+
target 'Facebook' do
65+
# Pods for Facebook Auth
66+
pod 'Firebase/Auth'
67+
pod 'FBSDKLoginKit', '~> 4.0'
68+
end
69+
70+
target 'Google' do
71+
# Pods for Google Auth
72+
pod 'Firebase/Auth'
73+
pod 'GoogleSignIn', '~> 4.0'
74+
end

build.swift

Lines changed: 31 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,13 @@ let schemes = [
102102
"FirebaseGoogleAuthUI",
103103
]
104104

105+
let staticLibs = [
106+
"Database": "FirebaseDatabaseUI",
107+
"Auth" : "FirebaseAuthUI",
108+
"Facebook": "FirebaseFacebookAuthUI",
109+
"Google" : "FirebaseGoogleAuthUI",
110+
]
111+
105112
// make folder structure for built products
106113
schemes.forEach { scheme in
107114
let schemeDir = BuiltProductsDir + scheme
@@ -110,9 +117,23 @@ schemes.forEach { scheme in
110117
}
111118

112119
// Invoke xcodebuild, building each scheme in
113-
// release for each target sdk
114-
let builds = sdks.flatMap { sdk in
115-
return schemes.map { scheme in
120+
// release for each target sdk. Building
121+
// dynamic frameworks so we don't have to do
122+
// the asset bundling and folder structures manually,
123+
// at the costs of lots of duplication. Not sure if ideal.
124+
let builds = schemes.map { scheme in
125+
return Build([
126+
"-workspace" : "FirebaseUI.xcworkspace",
127+
"-scheme" : scheme,
128+
"-configuration" : "Release",
129+
"-sdk" : sdks[0],
130+
"-derivedDataPath": DerivedDataDir,
131+
])
132+
}
133+
134+
let staticBuilds: [Build] = sdks.flatMap { sdk -> [Build] in
135+
let schemeNames = Array(staticLibs.keys)
136+
return schemeNames.map { scheme -> Build in
116137
return Build([
117138
"-workspace" : "FirebaseUI.xcworkspace",
118139
"-scheme" : scheme,
@@ -124,6 +145,7 @@ let builds = sdks.flatMap { sdk in
124145
}
125146

126147
builds.forEach { $0.launch() }
148+
staticBuilds.forEach { $0.launch() }
127149

128150
// Copy frameworks into built products dir. Don't really
129151
// care about sdk here since we're gonna lipo everything later
@@ -161,16 +183,16 @@ let productsPaths = sdks.map {
161183
}
162184

163185
// create lipo tasks from built products
164-
let lipos: [Lipo] = schemes.map { scheme in
165-
let framework = "\(scheme).framework"
166-
let binary = scheme
186+
let lipos: [Lipo] = Array(staticLibs.keys).map { scheme in
187+
let product = staticLibs[scheme]!
188+
let framework = "\(product).framework"
189+
let binary = "lib\(scheme).a"
167190

168-
let lib = "\(scheme).framework/\(scheme)"
169191
let chunks = productsPaths.map { path in
170-
return path + lib
192+
return path + binary
171193
}
172194

173-
let output = "\(BuiltProductsDir)\(scheme)/Frameworks/\(framework)/\(binary)"
195+
let output = "\(BuiltProductsDir)\(product)/Frameworks/\(framework)/\(product)"
174196
return Lipo(inputs: chunks, output: output)
175197
}
176198

0 commit comments

Comments
 (0)