Skip to content

Commit d142c9a

Browse files
committed
🧹 simplify regression triggers + remove CI optimization doc
1 parent c3c1e89 commit d142c9a

File tree

6 files changed

+9
-128
lines changed

6 files changed

+9
-128
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,12 @@ jobs:
3333
- "src/lib/stores/runtimeDebugStore.ts"
3434
- "src/lib/stores/taskStore.ts"
3535
- "src/lib/__tests__/integration/**"
36-
- "mise.toml"
37-
- "mise-tasks/test-*"
3836
- "scripts/testing/**"
39-
- "scripts/git-hooks/pre-push"
40-
- ".github/workflows/ci.yml"
37+
- "mise-tasks/runtime-build*"
4138
rust:
4239
- ".cargo/**"
4340
- "src-tauri/**"
4441
- "mise.toml"
45-
- ".github/workflows/ci.yml"
4642
4743
check:
4844
name: check (fast)

‎TODO.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
- [x] Add path-aware regression gating for push/CI so live tests only run when integration-impacting files changed.
1717
- [ ] Burn in the CI/hook split gate behavior (`check-full` skip/run on path filters + `PIWORK_FORCE_CHECK_FULL=1` local pre-push path), then mark this parent item done.
1818
- [x] Add fast protocol guardrail (`mise run audit-protocol`) via Vitest contract tests.
19-
- [ ] **CI/local gate alignment + cache policy cleanup (P0 ergonomics)** — remove path-detection magic/duplication between CI filters and local scripts, and make cache behavior explicit (`docs/ci-optimization-plan.md`).
19+
- [ ] **CI/local gate alignment + cache policy cleanup (P0 ergonomics)** — reduce path-detection magic and keep CI/local gating behavior predictable.
2020
- Decide whether docs-only changes should run a no-op gate vs lightweight docs validation.
21-
- Move path groups into one shared definition and reuse it across CI + local hooks.
21+
- Keep integration trigger lists explicit and scoped to runtime-impacting paths (CI + local pre-push should stay in sync).
2222
- Reconcile Rust cache strategy (`rust-cache` sharing between jobs, optional sccache persistence experiment) and keep observable metrics in logs.
2323
- Revisit trigger: after 5–10 mixed pushes (docs-only, frontend-only, rust/integration) with expected run/skip behavior and predictable cache hit patterns.
2424
- [ ] **Reactive model/bootstrap sequencing (P0 stability)** — move runtime model setup from timeout-driven polling to explicit task readiness states.

‎docs/README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525

2626
## Supporting
2727

28-
- `ci-optimization-plan.md` — CI/local gate alignment plan, cache strategy, and rollout phases
2928
- `path-i-lite-negative-suite.md` — scope enforcement test (traversal/symlink/cross-task)
3029
- `network-mitm-spike.md` — future network interception notes
3130

‎docs/ci-optimization-plan.md‎

Lines changed: 0 additions & 118 deletions
This file was deleted.

‎scripts/testing/run-regressions.sh‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ ensure_runtime_pack() {
3131

3232
if [[ "${PIWORK_RUNTIME_CACHE_HIT:-}" == "true" ]]; then
3333
echo "[runtime-build] cache hit reported, but runtime pack is missing/incomplete at $dir; rebuilding"
34-
else
34+
elif [[ "${CI:-}" == "true" ]]; then
3535
echo "[runtime-build] cache miss; rebuilding runtime pack"
36+
elif runtime_pack_is_ready "$dir"; then
37+
echo "[runtime-build] local run: runtime pack present; checking freshness via mise sources"
38+
else
39+
echo "[runtime-build] local run: runtime pack missing/incomplete; building"
3640
fi
3741

3842
mise run runtime-build

‎scripts/testing/should-run-regressions.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ if [[ -z "$CHANGED" ]]; then
3030
exit 1
3131
fi
3232

33-
PATTERN='^(runtime/|src-tauri/src/|src/lib/components/layout/|src/lib/services/runtimeService\.ts$|src/lib/stores/(runtimeDebugStore|taskStore)\.ts$|src/lib/__tests__/integration/|mise\.toml$|mise-tasks/test-|scripts/git-hooks/pre-push$|scripts/testing/|\.github/workflows/ci\.yml$)'
33+
PATTERN='^(runtime/|src-tauri/src/|src/lib/components/layout/|src/lib/services/runtimeService\.ts$|src/lib/stores/(runtimeDebugStore|taskStore)\.ts$|src/lib/__tests__/integration/|scripts/testing/|mise-tasks/runtime-build)'
3434

3535
if ! printf '%s\n' "$CHANGED" | grep -Eq "$PATTERN"; then
3636
echo "[regressions] no integration-impacting files changed; skipping regressions"

0 commit comments

Comments
 (0)