From 39655ee0b8bca6bdf1d326a01f7b96adf499f92f Mon Sep 17 00:00:00 2001 From: Michael Droettboom Date: Mon, 23 Jun 2025 14:42:06 -0400 Subject: [PATCH 1/2] No pystats warmups --- CHANGELOG.md | 5 +++++ bench_runner/benchmark_definitions.py | 2 +- bench_runner/scripts/run_benchmarks.py | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 675a9c26..c9478496 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ ### Bugfixes +#### No warmup runs for pystats + +When collecting pystats, pyperformance will no longer perform "warmup runs", to +make sure that the pystats don't have missing information. + #### Removing a git repo on Windows fails One needs to remove the "read only" flags on certain files in the git repo in order to remove it. diff --git a/bench_runner/benchmark_definitions.py b/bench_runner/benchmark_definitions.py index 5ea214b4..577be504 100644 --- a/bench_runner/benchmark_definitions.py +++ b/bench_runner/benchmark_definitions.py @@ -18,7 +18,7 @@ class BenchmarkRepo: BENCHMARK_REPOS = [ BenchmarkRepo( - "56d12a8fd7cc1432835965d374929bfa7f6f7a07", + "29cd683acc3eddfd878aa87ef52c15aa4a53641e", "https://github.com/python/pyperformance.git", "pyperformance", ), diff --git a/bench_runner/scripts/run_benchmarks.py b/bench_runner/scripts/run_benchmarks.py index 5a0e204d..293e50cc 100644 --- a/bench_runner/scripts/run_benchmarks.py +++ b/bench_runner/scripts/run_benchmarks.py @@ -145,7 +145,7 @@ def collect_pystats( if LOOPS_FILE_ENV_VAR not in os.environ: os.environ[LOOPS_FILE_ENV_VAR] = "loops.json" - extra_args = ["--hook", "pystats"] + extra_args = ["--hook", "pystats", "--warmups", "0"] if flags is None: flags = [] From ed6faed7ef008bdaaa34c92c75573199dcfbcf71 Mon Sep 17 00:00:00 2001 From: Michael Droettboom Date: Tue, 24 Jun 2025 11:43:36 -0400 Subject: [PATCH 2/2] Remove nonsensical test --- tests/test_run_benchmarks.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/test_run_benchmarks.py b/tests/test_run_benchmarks.py index 3cdf6572..74e7c1e2 100644 --- a/tests/test_run_benchmarks.py +++ b/tests/test_run_benchmarks.py @@ -192,7 +192,3 @@ def test_run_benchmarks_flags(benchmarks_checkout): f"python-main-{platform.python_version()}-9d38120.json" ) as fd: json.load(fd) - - -def test_get_benchmark_hash(): - assert benchmark_definitions.get_benchmark_hash() == "dcfded"