Skip to content

Commit 9ef8a60

Browse files
committed
Fix mock patching in test_check_nvidia_smi_hal_parity.py
1 parent c6b0855 commit 9ef8a60

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

gcm/tests/health_checks_tests/test_check_nvidia_smi_hal_parity.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Copyright (c) Meta Platforms, Inc. and affiliates.
22
# All rights reserved.
3+
import sys
34
from unittest.mock import patch
45

56
from gcm.health_checks.checks.check_nvidia_smi import NvidiaSmiCliImpl
@@ -8,11 +9,13 @@
89

910
def test_nvidia_smi_cli_impl_uses_hal_adapter() -> None:
1011
# Patch default_backend_factories to avoid actual registry access
12+
# We use patch.object on the module to avoid ambiguity because
13+
# gcm.health_checks.checks.check_nvidia_smi resolves to the command function
14+
# when accessed via package attribute traversal in mock.patch string.
15+
module = sys.modules[NvidiaSmiCliImpl.__module__]
1116
with (
12-
patch("gcm.health_checks.checks.check_nvidia_smi.default_backend_factories"),
13-
patch(
14-
"gcm.health_checks.checks.check_nvidia_smi.AcceleratorManager"
15-
) as MockManager,
17+
patch.object(module, "default_backend_factories"),
18+
patch.object(module, "AcceleratorManager") as MockManager,
1619
):
1720
# Mock manager instance
1821
manager_instance = MockManager.return_value

0 commit comments

Comments
 (0)