Skip to content

Commit d0fdadc

Browse files
chadaustinfacebook-github-bot
authored andcommitted
if the record_results endpoint fails, don't fail the job
Summary: A request to record_results failed, which caused a folly gcc 8 build regression to slip in, which broke the Watchman and EdenFS builds. Instead, turn record_results requests into a logged warning. Reviewed By: xavierd Differential Revision: D38170729 fbshipit-source-id: d59ae5fa48b5cbcf649281108d958ff95e319e35
1 parent 7b73701 commit d0fdadc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

build/fbcode_builder/getdeps/builder.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,8 @@ def list_tests():
850850
testpilot_args.append("--env")
851851
testpilot_args.extend(f"{key}={val}" for key, val in env.items())
852852

853-
testpilot_args += ["--run-id", str(run_id)]
853+
if run_id is not None:
854+
testpilot_args += ["--run-id", run_id]
854855

855856
if test_filter:
856857
testpilot_args += ["--", test_filter]

0 commit comments

Comments
 (0)