Skip to content

Commit 7effb9e

Browse files
jagillmeta-codesync[bot]
authored andcommitted
feat(geo): Increase default BingTile zoom shift from 6 to 7 (#15759)
Summary: Pull Request resolved: #15759 The session parameter debug_bing_tile_children_max_zoom_shift controls the max difference in zoom (zoom shift) between parent bing tile and child. The number of children scales like `4 ** zoom_shift`, so bounding this prevents some OOMs. In production we are finding zoom shift 7 queries running fine, so increase this shift so they can run. Reviewed By: Sullivan-Patrick Differential Revision: D89079085 fbshipit-source-id: f42cb430d0cf8f69a2e3a1004e0a32d2e9733ff8
1 parent 4bb8f85 commit 7effb9e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

velox/core/QueryConfig.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@ class QueryConfig {
817817
}
818818

819819
uint8_t debugBingTileChildrenMaxZoomShift() const {
820-
return get<uint8_t>(kDebugBingTileChildrenMaxZoomShift, 6);
820+
return get<uint8_t>(kDebugBingTileChildrenMaxZoomShift, 7);
821821
}
822822

823823
uint64_t queryMaxMemoryPerNode() const {

velox/functions/prestosql/tests/BingTileFunctionsTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,8 @@ TEST_F(BingTileFunctionsTest, bingTileChildrenZoom) {
459459
VELOX_ASSERT_USER_THROW(
460460
testBingTileChildren(0, 0, 2, 1), "Child zoom 1 must be >= tile zoom 2");
461461
VELOX_ASSERT_USER_THROW(
462-
testBingTileChildren(0, 0, 1, 8),
463-
"Difference between parent zoom (1) and child zoom (8) must be <= 6");
462+
testBingTileChildren(0, 0, 1, 9),
463+
"Difference between parent zoom (1) and child zoom (9) must be <= 7");
464464

465465
{
466466
RowVectorPtr input = makeSingleXYZoomZoomRow(0, 0, 1, 7);

0 commit comments

Comments
 (0)