Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit fdf63aa

Browse files
Claudio Procidafacebook-github-bot
Claudio Procida
authored and
facebook-github-bot
committed
Handles <br> tags in refactored HTML converter
Summary: This diff aligns the refactored HTML converter with the legacy one to correctly handle <br> tags Reviewed By: mitermayer Differential Revision: D14027112 fbshipit-source-id: 68c2ae2272bac4e2d90a72b71cfb43f7b20faa3a
1 parent b4183b1 commit fdf63aa

File tree

5 files changed

+800
-16
lines changed

5 files changed

+800
-16
lines changed

‎src/model/encoding/__tests__/__snapshots__/convertFromHTMLToContentBlocks-test.js.snap

Lines changed: 383 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,6 +1579,389 @@ exports[`img with http protocol should have camera emoji content 1`] = `"📷"`;
15791579

15801580
exports[`img with role presentation should not be rendered 1`] = `null`;
15811581

1582+
exports[`line break should be correctly parsed - multiple <br> in a content block 1`] = `
1583+
Array [
1584+
Immutable.Record {
1585+
"key": "key0",
1586+
"type": "unstyled",
1587+
"text": "Hello World!
1588+
",
1589+
"characterList": Immutable.List [
1590+
Immutable.Record {
1591+
"style": Immutable.OrderedSet [
1592+
"BOLD",
1593+
],
1594+
"entity": null,
1595+
},
1596+
Immutable.Record {
1597+
"style": Immutable.OrderedSet [
1598+
"BOLD",
1599+
],
1600+
"entity": null,
1601+
},
1602+
Immutable.Record {
1603+
"style": Immutable.OrderedSet [
1604+
"BOLD",
1605+
],
1606+
"entity": null,
1607+
},
1608+
Immutable.Record {
1609+
"style": Immutable.OrderedSet [
1610+
"BOLD",
1611+
],
1612+
"entity": null,
1613+
},
1614+
Immutable.Record {
1615+
"style": Immutable.OrderedSet [
1616+
"BOLD",
1617+
],
1618+
"entity": null,
1619+
},
1620+
Immutable.Record {
1621+
"style": Immutable.OrderedSet [
1622+
"BOLD",
1623+
],
1624+
"entity": null,
1625+
},
1626+
Immutable.Record {
1627+
"style": Immutable.OrderedSet [
1628+
"BOLD",
1629+
],
1630+
"entity": null,
1631+
},
1632+
Immutable.Record {
1633+
"style": Immutable.OrderedSet [
1634+
"BOLD",
1635+
],
1636+
"entity": null,
1637+
},
1638+
Immutable.Record {
1639+
"style": Immutable.OrderedSet [
1640+
"BOLD",
1641+
],
1642+
"entity": null,
1643+
},
1644+
Immutable.Record {
1645+
"style": Immutable.OrderedSet [
1646+
"BOLD",
1647+
],
1648+
"entity": null,
1649+
},
1650+
Immutable.Record {
1651+
"style": Immutable.OrderedSet [
1652+
"BOLD",
1653+
],
1654+
"entity": null,
1655+
},
1656+
Immutable.Record {
1657+
"style": Immutable.OrderedSet [
1658+
"BOLD",
1659+
],
1660+
"entity": null,
1661+
},
1662+
Immutable.Record {
1663+
"style": Immutable.OrderedSet [],
1664+
"entity": null,
1665+
},
1666+
Immutable.Record {
1667+
"style": Immutable.OrderedSet [],
1668+
"entity": null,
1669+
},
1670+
Immutable.Record {
1671+
"style": Immutable.OrderedSet [],
1672+
"entity": null,
1673+
},
1674+
],
1675+
"depth": 0,
1676+
"data": Immutable.Map {},
1677+
},
1678+
Immutable.Record {
1679+
"key": "key1",
1680+
"type": "unstyled",
1681+
"text": " lorem ipsum ",
1682+
"characterList": Immutable.List [
1683+
Immutable.Record {
1684+
"style": Immutable.OrderedSet [],
1685+
"entity": null,
1686+
},
1687+
Immutable.Record {
1688+
"style": Immutable.OrderedSet [],
1689+
"entity": null,
1690+
},
1691+
Immutable.Record {
1692+
"style": Immutable.OrderedSet [],
1693+
"entity": null,
1694+
},
1695+
Immutable.Record {
1696+
"style": Immutable.OrderedSet [],
1697+
"entity": null,
1698+
},
1699+
Immutable.Record {
1700+
"style": Immutable.OrderedSet [],
1701+
"entity": null,
1702+
},
1703+
Immutable.Record {
1704+
"style": Immutable.OrderedSet [],
1705+
"entity": null,
1706+
},
1707+
Immutable.Record {
1708+
"style": Immutable.OrderedSet [],
1709+
"entity": null,
1710+
},
1711+
Immutable.Record {
1712+
"style": Immutable.OrderedSet [],
1713+
"entity": null,
1714+
},
1715+
Immutable.Record {
1716+
"style": Immutable.OrderedSet [],
1717+
"entity": null,
1718+
},
1719+
Immutable.Record {
1720+
"style": Immutable.OrderedSet [],
1721+
"entity": null,
1722+
},
1723+
Immutable.Record {
1724+
"style": Immutable.OrderedSet [],
1725+
"entity": null,
1726+
},
1727+
Immutable.Record {
1728+
"style": Immutable.OrderedSet [],
1729+
"entity": null,
1730+
},
1731+
Immutable.Record {
1732+
"style": Immutable.OrderedSet [],
1733+
"entity": null,
1734+
},
1735+
Immutable.Record {
1736+
"style": Immutable.OrderedSet [],
1737+
"entity": null,
1738+
},
1739+
Immutable.Record {
1740+
"style": Immutable.OrderedSet [],
1741+
"entity": null,
1742+
},
1743+
Immutable.Record {
1744+
"style": Immutable.OrderedSet [],
1745+
"entity": null,
1746+
},
1747+
Immutable.Record {
1748+
"style": Immutable.OrderedSet [],
1749+
"entity": null,
1750+
},
1751+
Immutable.Record {
1752+
"style": Immutable.OrderedSet [],
1753+
"entity": null,
1754+
},
1755+
Immutable.Record {
1756+
"style": Immutable.OrderedSet [],
1757+
"entity": null,
1758+
},
1759+
Immutable.Record {
1760+
"style": Immutable.OrderedSet [],
1761+
"entity": null,
1762+
},
1763+
Immutable.Record {
1764+
"style": Immutable.OrderedSet [],
1765+
"entity": null,
1766+
},
1767+
Immutable.Record {
1768+
"style": Immutable.OrderedSet [],
1769+
"entity": null,
1770+
},
1771+
],
1772+
"depth": 0,
1773+
"data": Immutable.Map {},
1774+
},
1775+
]
1776+
`;
1777+
1778+
exports[`line break should be correctly parsed - single <br> 1`] = `
1779+
Array [
1780+
Immutable.Record {
1781+
"key": "key0",
1782+
"type": "unstyled",
1783+
"text": "Hello World!
1784+
lorem ipsum ",
1785+
"characterList": Immutable.List [
1786+
Immutable.Record {
1787+
"style": Immutable.OrderedSet [
1788+
"BOLD",
1789+
],
1790+
"entity": null,
1791+
},
1792+
Immutable.Record {
1793+
"style": Immutable.OrderedSet [
1794+
"BOLD",
1795+
],
1796+
"entity": null,
1797+
},
1798+
Immutable.Record {
1799+
"style": Immutable.OrderedSet [
1800+
"BOLD",
1801+
],
1802+
"entity": null,
1803+
},
1804+
Immutable.Record {
1805+
"style": Immutable.OrderedSet [
1806+
"BOLD",
1807+
],
1808+
"entity": null,
1809+
},
1810+
Immutable.Record {
1811+
"style": Immutable.OrderedSet [
1812+
"BOLD",
1813+
],
1814+
"entity": null,
1815+
},
1816+
Immutable.Record {
1817+
"style": Immutable.OrderedSet [
1818+
"BOLD",
1819+
],
1820+
"entity": null,
1821+
},
1822+
Immutable.Record {
1823+
"style": Immutable.OrderedSet [
1824+
"BOLD",
1825+
],
1826+
"entity": null,
1827+
},
1828+
Immutable.Record {
1829+
"style": Immutable.OrderedSet [
1830+
"BOLD",
1831+
],
1832+
"entity": null,
1833+
},
1834+
Immutable.Record {
1835+
"style": Immutable.OrderedSet [
1836+
"BOLD",
1837+
],
1838+
"entity": null,
1839+
},
1840+
Immutable.Record {
1841+
"style": Immutable.OrderedSet [
1842+
"BOLD",
1843+
],
1844+
"entity": null,
1845+
},
1846+
Immutable.Record {
1847+
"style": Immutable.OrderedSet [
1848+
"BOLD",
1849+
],
1850+
"entity": null,
1851+
},
1852+
Immutable.Record {
1853+
"style": Immutable.OrderedSet [
1854+
"BOLD",
1855+
],
1856+
"entity": null,
1857+
},
1858+
Immutable.Record {
1859+
"style": Immutable.OrderedSet [],
1860+
"entity": null,
1861+
},
1862+
Immutable.Record {
1863+
"style": Immutable.OrderedSet [],
1864+
"entity": null,
1865+
},
1866+
Immutable.Record {
1867+
"style": Immutable.OrderedSet [],
1868+
"entity": null,
1869+
},
1870+
Immutable.Record {
1871+
"style": Immutable.OrderedSet [],
1872+
"entity": null,
1873+
},
1874+
Immutable.Record {
1875+
"style": Immutable.OrderedSet [],
1876+
"entity": null,
1877+
},
1878+
Immutable.Record {
1879+
"style": Immutable.OrderedSet [],
1880+
"entity": null,
1881+
},
1882+
Immutable.Record {
1883+
"style": Immutable.OrderedSet [],
1884+
"entity": null,
1885+
},
1886+
Immutable.Record {
1887+
"style": Immutable.OrderedSet [],
1888+
"entity": null,
1889+
},
1890+
Immutable.Record {
1891+
"style": Immutable.OrderedSet [],
1892+
"entity": null,
1893+
},
1894+
Immutable.Record {
1895+
"style": Immutable.OrderedSet [],
1896+
"entity": null,
1897+
},
1898+
Immutable.Record {
1899+
"style": Immutable.OrderedSet [],
1900+
"entity": null,
1901+
},
1902+
Immutable.Record {
1903+
"style": Immutable.OrderedSet [],
1904+
"entity": null,
1905+
},
1906+
Immutable.Record {
1907+
"style": Immutable.OrderedSet [],
1908+
"entity": null,
1909+
},
1910+
Immutable.Record {
1911+
"style": Immutable.OrderedSet [],
1912+
"entity": null,
1913+
},
1914+
Immutable.Record {
1915+
"style": Immutable.OrderedSet [],
1916+
"entity": null,
1917+
},
1918+
Immutable.Record {
1919+
"style": Immutable.OrderedSet [],
1920+
"entity": null,
1921+
},
1922+
Immutable.Record {
1923+
"style": Immutable.OrderedSet [],
1924+
"entity": null,
1925+
},
1926+
Immutable.Record {
1927+
"style": Immutable.OrderedSet [],
1928+
"entity": null,
1929+
},
1930+
Immutable.Record {
1931+
"style": Immutable.OrderedSet [],
1932+
"entity": null,
1933+
},
1934+
Immutable.Record {
1935+
"style": Immutable.OrderedSet [],
1936+
"entity": null,
1937+
},
1938+
Immutable.Record {
1939+
"style": Immutable.OrderedSet [],
1940+
"entity": null,
1941+
},
1942+
Immutable.Record {
1943+
"style": Immutable.OrderedSet [],
1944+
"entity": null,
1945+
},
1946+
Immutable.Record {
1947+
"style": Immutable.OrderedSet [],
1948+
"entity": null,
1949+
},
1950+
Immutable.Record {
1951+
"style": Immutable.OrderedSet [],
1952+
"entity": null,
1953+
},
1954+
Immutable.Record {
1955+
"style": Immutable.OrderedSet [],
1956+
"entity": null,
1957+
},
1958+
],
1959+
"depth": 0,
1960+
"data": Immutable.Map {},
1961+
},
1962+
]
1963+
`;
1964+
15821965
exports[`must convert root ContentBlockNodes to matching ContentBlock nodes for <blockquote /> 1`] = `true`;
15831966
15841967
exports[`must convert root ContentBlockNodes to matching ContentBlock nodes for <div /> 1`] = `true`;

0 commit comments

Comments
 (0)