|
| 1 | +# Draft.js Meeting Notes - 9/7 |
| 2 | +## Attendees |
| 3 | +- Claudio (Facebook, data center tools team in Dublin) |
| 4 | +- Flarnie (Facebook, long-time maintainer who is transitioning away) |
| 5 | +- Julian (Maintainer of https://github.com/draft-js-plugins) |
| 6 | +- Marco (Facebook, Workplace team in London) |
| 7 | +- Nivedita (Facebook, Internal Tools team) |
| 8 | +- Yuze (Twitter, leading the Draft.js integration for Twitter) |
| 9 | + |
| 10 | +## Project Updates |
| 11 | +**Tree Data implementation** (Nivedita) |
| 12 | + |
| 13 | +- The current block list model is ill-suited for tables, layouts \& other complex behaviours. |
| 14 | +- Tables are important for some FB-internal tools \& tree data is the best way to implement these. |
| 15 | +- Bulk of this work was implemented by Mitermayer \& Flarnie; Nivedita is currently implementing a few missing pieces \& getting it ready to test on FB internal tools. |
| 16 | +- No plans at the moment to migrate other FB usages to the tree data model and/or deprecate the current data model. |
| 17 | + |
| 18 | +**Twitter** (Yuze) |
| 19 | + |
| 20 | +- They have forked Draft and made some incremental changes. |
| 21 | +- React \& Draft are being used in the new version of the website. |
| 22 | +- They are planning to contribute some issues \& PRs back to Draft related to their work. |
| 23 | +- They had earlier planned to work on making mobile support more resilient but it is not currently on their near-term roadmap. |
| 24 | + |
| 25 | +## Discussion |
| 26 | +**What are the biggest pain points around working with Draft.js today?** |
| 27 | + |
| 28 | +The main issue is that it is hard to contribute (get your PR addressed/issue fixed) \& lack of response / timeliness makes potential contributors reluctant to submit PRs. |
| 29 | + |
| 30 | +- There is no clear guidance on what it would take for a PR to get reviewed \& accepted. |
| 31 | +- The two pain points from the FB maintainer side have been: |
| 32 | + - Lack of resources (this is still a side project for everyone rather than a team owning Draft.js, but hopefully with more maintainers now we can contribute a few hours every week between us). |
| 33 | + - Needing to ensure (via a manual process) that external PRs don't break Facebook, which is why we have been very conservative. |
| 34 | +- What can help? |
| 35 | + - Clear guidelines on what PRs need to have to get accepted. |
| 36 | + - Better suite of test cases - possibly we can get help from the OS community on this. |
| 37 | + - If possible, a way to expose some way to run part or all of the FB test suite. |
| 38 | + - Codify part or all of the manual test process if possible. |
| 39 | +- Action Items (potentially over the next month): |
| 40 | + - Explore some of the existing PRs to evaluate whether or not they can be pulled in. |
| 41 | + - Come up with some better guidelines for PRs \& communicate these to the community. |
| 42 | + - Figure out what test cases are missing \& seek out the community's help in adding these to the project. |
| 43 | + |
| 44 | +**Brainstorm of ways in which we can deal with existing issues \& PRs** |
| 45 | + |
| 46 | +- Bug bash |
| 47 | +- Take a pass at adding tags \& labels for issues (such as \`good first issue\`). |
| 48 | +- Create a more active community, which is more involved in fixing issues. Conferences / events / meetups. |
| 49 | + |
| 50 | +**Release process** |
| 51 | + |
| 52 | +- Flarnie used to do regular releases every few weeks or months, but didn't have as much time over the past few months. |
| 53 | +- We wanted to cut 0.11 but there were some breaking changes - getting this shipped is low-pri. |
| 54 | +- We could remove the two-way sync into Facebook master to let the open source community contribute without as much friction. |
| 55 | +- But it will be really hard to get these back in sync / pull changes in. |
| 56 | +- Yuze gains confidence to pull in latest commits into their fork because Facebook is using this continuously. |
| 57 | +- We agreed that forking is a bad idea. |
| 58 | + |
| 59 | +Next meeting will be in two weeks. |
0 commit comments