Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit 1ef4044

Browse files
flarniefacebook-github-bot
flarnie
authored and
facebook-github-bot
committed
Update biweekly sync meeting notes from February 2018
Summary: (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧ Maybe some day we will support mobile web. Closes #1663 Differential Revision: D7086767 fbshipit-source-id: 63b4a1c5bc0fa4f21fbd5aa850039db37587a270
1 parent 4de1345 commit 1ef4044

File tree

2 files changed

+93
-0
lines changed

2 files changed

+93
-0
lines changed

‎meta/meeting-notes/2018-02-08-weekly-meeting.md

Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
# Draft.js Weekly 02/08/18
2+
3+
* Intros - welcome to Twitter web team! 🎉
4+
* Discussion:
5+
* Twitter team planning to try Draft.js for their Web UIs
6+
* We can commit to regularly merge their PRs
7+
* TODO: get a list of their github handles, to respond to their PRs in particular.
8+
* Their discussion items:
9+
* They will use it on mobile
10+
* It will take a while to go public, they will focus on quality
11+
* Asking about test coverage
12+
* We need more :)
13+
* What will the flow be?
14+
* internal PR and review
15+
* Should they write a feature flag into their code
16+
* TODO: send them a link to the file with feature flags changes recently
17+
* Mobile bugs
18+
* using default android keyboard and pressing space
19+
* MS swift keyboard
20+
* other major issues?
21+
* Sophie - Right now Draft.js keeps state of DOM and editor in sync
22+
* it does this by listening to each event, then updating internal state
23+
* in some cases Draft.js will call event.preventDefault on event, and in others we allow native event to happen
24+
* Doesn't happen much but we try to allow it when we can. Spellcheck is an example.
25+
* the issue is on Android, they don't send input events for a lot of the things that you would want them for. They only send a single input event, not keypress, not beforeInput, etc. and input event doesn't have keycode. Only way to figure out what happened is look at DOM and diff, figure out what changed.
26+
* So far we have not implemented anything like that, because all other browsers do sent useful events and it's a big refactor.
27+
* It would be possible, but a substantial amount of work. Needs to be done to support Android.
28+
* Seems to be a challenge of contenteditable on any framework.
29+
* Twitter lead -
30+
* They want to go in this direction, happy we are supportive.
31+
* Sophie
32+
* She can talk more about how this could work.
33+
* Twitter lead -
34+
* Where does FB fallback to textarea?
35+
* Sophie
36+
* Depends. Recently decided to exclude iOS and using Chinese/Japanese bc of IME bugs in iOS.
37+
* Depends on your users and features. Doesn't matter that much for that case.
38+
* Twitter lead -
39+
* Problems with some languages - on desktop or mobile web? Facebook only uses it on desktop right?
40+
* Sophie
41+
* Generally right, only desktop.
42+
* Twitter lead -
43+
* Do you think it's a big problem with IME?
44+
* Sophie
45+
* We do have some problems with IME in IE, up to IE 11 but Edge is ok.
46+
* That's similar to what happens on android, where it doesn't send the events we need.
47+
* Right now we exclude cjk languages from getting Draft input on IE. IE is a small fraction for us.
48+
* Twitter lead -
49+
* Long term tehy would like to see Draft.js be configurable, in terms of decreasing the bundle size. It's a hard thing to do.
50+
* One concern is the size.
51+
* Alan
52+
* Do you have specific goals, how small would it be if it wasn't a problem?
53+
* Twitter lead -
54+
* 70k is a little big
55+
* They don't use immutable-js, they don't care about “large error maps”
56+
* old compose bundle was ~30k gzipped
57+
* importing draft.js increases to ~90kb
58+
* Flarnie
59+
* More details on the approach proposed?
60+
* Sophie
61+
* Could do everything that way
62+
* More about how we can do this?
63+
* Could do it incrementally - Twitter team has done similar things with their previous editor
64+
* Do we rewrite or incrementally
65+
* How to work through this?
66+
* Sophie - start with a meeting to walk through how it works, Sophie can give that
67+
* We will follow up via email about the
68+
69+
*Action Items:*
70+
71+
* Put out internal task to refactor https://github.com/facebook/draft-js/blob/master/src/model/encoding/convertFromHTMLToContentBlocks.js (Flarnie)
72+
* Get list of Twitter team github handles (Flarnie)
73+
* Set up meeting with Twitter folks to explain Draft architecture (Sophie)
74+
* Email about next steps (Sophie and/or Flarnie)
75+
76+
77+

‎meta/meeting-notes/2018-02-23-weekly-meeting.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# Draft.js Weekly 02/08/18
2+
3+
* DELAYED until next week: Demo of new filesize tracking courtesy of Alan Norbauer
4+
* in https://github.com/facebook/draft-js/pull/1644
5+
6+
* Update from Twitter team
7+
* Working on integrating Draft into their composer, no changes yet
8+
* They have a prototype on mobile, iOS is ok except for autocorrect
9+
* on Android there are some keyboards that don't accept any input from users. Major issues needing fixed.
10+
* Looking into Chrome 65 issue, where mouse movement triggers composition events
11+
* https://github.com/facebook/draft-js/issues/1657
12+
* Update coming next time about tree block data structure support
13+
* Isaac and Sophie discussing mobile support
14+
* Sophie: preventing/controlling events seems to not work on android
15+
* Isaac: yea, that might be the direction to go in, since android and now Chrome don't have consistent event systems
16+
* Overall consensus - if Twitter folks can put in effort, we support rearchiteture of Draft.js to better support mobile web.

0 commit comments

Comments
 (0)