Skip to content

Commit 5c7555b

Browse files
Expose Sink type from relay-runtime (#4516)
Summary: I want to suggest exporting `Sink` & `Source` types so they can be used to type the argument of `Observable.create`, e.g. something like this: ```js import { Observable } from 'relay-runtime'; const responseHandler = () => {} // Here I would like to use either Source or Sink types export const createRequestHandler = (customFetcher: Fetcher) => (request: RequestParameters, variables: Variables, cacheConfig: CacheConfig) => { const observable = Observable.create(sink => { void customFetcher(request, variables, cacheConfig) .then(responseHandler(sink)) .catch((error: Error) => { sink.error(error); }) .then(() => { sink.complete(); }); }); return observable; }; ``` Pull Request resolved: #4516 Reviewed By: captbaritone Differential Revision: D51027312 Pulled By: alunyov fbshipit-source-id: 9f2cff94e70c436acc9c8498ec890293584dc36b
1 parent 9e0acc1 commit 5c7555b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/relay-runtime/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ export type {
106106
export type {
107107
ObservableFromValue,
108108
Observer,
109+
Sink,
110+
Source,
109111
Subscribable,
110112
Subscription,
111113
} from './network/RelayObservable';

0 commit comments

Comments
 (0)