Skip to content

Commit 3de18da

Browse files
captbaritonefacebook-github-bot
authored andcommitted
Fixups to quickstart (#4983)
Summary: I tried running the quickstart with 19 and hit two issues: 1. We need to update Babel to match the new compiler default of es modules: #4982 2. ~~We need to update our TS types to allow omitting store: DefinitelyTyped/DefinitelyTyped#72689 Merged and shipped Until those land, we should not have users expect those things to work Pull Request resolved: #4983 Reviewed By: evanyeung Differential Revision: D74214334 Pulled By: captbaritone fbshipit-source-id: 8c37f77165649eff67c1818bf8cdf263499ceb52
1 parent c6774c7 commit 3de18da

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

website/versioned_docs/version-v19.0.0/getting-started/quick-start.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ cd relay-example
3232
# Runtime dependencies
3333
npm install relay-runtime react-relay
3434
# Dev dependencies
35-
npm install --dev babel-plugin-relay graphql relay-compiler
35+
npm install --save-dev babel-plugin-relay graphql relay-compiler
3636
# Types
37-
npm install --dev @types/relay-runtime @types/react-relay
37+
npm install --save-dev @types/relay-runtime @types/react-relay
3838
```
3939

4040
## Configure Vite to use Relay
@@ -70,7 +70,8 @@ And define our `relay.config.json` config file which tells the [Relay Compiler](
7070
{
7171
"src": "./src",
7272
"schema": "./schema.graphql",
73-
"language": "typescript"
73+
"language": "typescript",
74+
"eagerEsModules": true
7475
}
7576
```
7677

0 commit comments

Comments
 (0)