Skip to content

[DiffTrain] Fix null artifactsUrl and add more logging #25768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Dec 1, 2022

Log more info on the status of the process_artifacts_combined job to help with debugging, and exit with exitcode 1 if anything goes wrong

Test plan: Ran the workflow successfully

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 1, 2022
@sizebot
Copy link

sizebot commented Dec 1, 2022

Comparing: 3ba7add...0cafaf2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.55 kB 154.55 kB = 49.04 kB 49.04 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.47 kB 156.47 kB = 49.67 kB 49.67 kB
facebook-www/ReactDOM-prod.classic.js = 533.67 kB 533.67 kB = 94.54 kB 94.54 kB
facebook-www/ReactDOM-prod.modern.js = 518.77 kB 518.77 kB = 92.35 kB 92.35 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.67 kB 533.67 kB = 94.54 kB 94.54 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0cafaf2

Log more info on the status of the process_artifacts_combined job
@poteto poteto merged commit 030dae2 into main Dec 1, 2022
@poteto poteto deleted the lt/difftrain branch December 1, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants