From aa2802189045e700dd40e23f44a1fa6646b123ac Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 7 Sep 2021 19:55:40 +0100 Subject: [PATCH 1/2] Move variant tests up --- .../forks/ReactFeatureFlags.www-dynamic.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js index e39892a106eca..56026250fc1c2 100644 --- a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js @@ -18,6 +18,13 @@ export const disableInputAttributeSyncing = __VARIANT__; export const enableFilterEmptyStringAttributesDOM = __VARIANT__; export const enableLegacyFBSupport = __VARIANT__; export const skipUnmountedBoundaries = __VARIANT__; +export const enableUseRefAccessWarning = __VARIANT__; +export const deletedTreeCleanUpLevel = __VARIANT__ ? 3 : 1; +export const enableProfilerNestedUpdateScheduledHook = __VARIANT__; +export const disableSchedulerTimeoutInWorkLoop = __VARIANT__; +export const enableLazyContextPropagation = __VARIANT__; +export const enableSyncDefaultUpdates = __VARIANT__; +export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__; // Enable this flag to help with concurrent mode debugging. // It logs information to the console about React scheduling, rendering, and commit phases. @@ -47,17 +54,8 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__; export const enableTrustedTypesIntegration = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; export const disableNativeComponentFrames = false; - export const createRootStrictEffectsByDefault = false; export const enableStrictEffects = false; -export const enableUseRefAccessWarning = __VARIANT__; -export const deletedTreeCleanUpLevel = __VARIANT__ ? 3 : 1; - -export const enableProfilerNestedUpdateScheduledHook = __VARIANT__; -export const disableSchedulerTimeoutInWorkLoop = __VARIANT__; -export const enableLazyContextPropagation = __VARIANT__; -export const enableSyncDefaultUpdates = __VARIANT__; export const allowConcurrentByDefault = true; export const enablePersistentOffscreenHostContainer = false; -export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__; From 59930038f82a11b8a7a922cc340c4dc5243a6153 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 7 Sep 2021 20:10:31 +0100 Subject: [PATCH 2/2] Add a comment --- packages/shared/forks/ReactFeatureFlags.www-dynamic.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js index 56026250fc1c2..366f1fd0a703b 100644 --- a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js @@ -58,4 +58,5 @@ export const createRootStrictEffectsByDefault = false; export const enableStrictEffects = false; export const allowConcurrentByDefault = true; export const enablePersistentOffscreenHostContainer = false; - +// You probably *don't* want to add more hardcoded ones. +// Instead, try to add them above with the __VARIANT__ value.