Always flush Default priority in the microtask if a Transition was scheduled too

Author: sebmarkbage

packages/react-reconciler/src/ReactFiberRootScheduler.js

@@ -26,6 +26,7 @@ import {
   NoLane,
   NoLanes,
   SyncLane,
+  DefaultLane,
   getHighestPriorityLane,
   getNextLanes,
   includesSyncLane,
@@ -261,6 +262,13 @@ function processRootScheduleInMicrotask() {
       // render it synchronously anyway. We do this during a popstate event to
       // preserve the scroll position of the previous page.
       syncTransitionLanes = currentEventTransitionLane;
+    } else if (enableDefaultTransitionIndicator) {
+      // If we have a Transition scheduled by this event it might be paired
+      // with Default lane scheduled loading indicators. To unbatch it from
+      // other events later on, flush it early to determine whether it
+      // rendered an indicator. This ensures that setState in default priority
+      // event doesn't trigger onDefaultTransitionIndicator.
+      syncTransitionLanes = DefaultLane;
     }
   }
 

packages/react-reconciler/src/__tests__/ReactDefaultTransitionIndicator-test.js

@@ -109,10 +109,7 @@ describe('ReactDefaultTransitionIndicator', () => {
     expect(root).toMatchRenderedOutput(<div>Hi</div>);
 
     await act(() => {
-      // TODO: This should not require a discrete update ideally but work for default too.
-      ReactNoop.discreteUpdates(() => {
-        update('Loading...');
-      });
+      update('Loading...');
       React.startTransition(() => {
         update('');
         root.render(<App>{promiseB}</App>);