Skip to content

Commit fb98e63

Browse files
committed
Clean up the enableEarlyReturnForPropDiffing experiment
1 parent 6ef0dd4 commit fb98e63

10 files changed

+0
-22
lines changed

packages/react-native-renderer/src/ReactNativeAttributePayload.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ import {
1414
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
1515
import isArray from 'shared/isArray';
1616

17-
import {enableEarlyReturnForPropDiffing} from 'shared/ReactFeatureFlags';
18-
1917
import type {AttributeConfiguration} from './ReactNativeTypes';
2018

2119
const emptyObject = {};
@@ -485,11 +483,6 @@ export function diff(
485483
nextProps: Object,
486484
validAttributes: AttributeConfiguration,
487485
): null | Object {
488-
if (enableEarlyReturnForPropDiffing) {
489-
if (prevProps === nextProps) {
490-
return null; // no change
491-
}
492-
}
493486
return diffProperties(
494487
null, // updatePayload
495488
prevProps,

packages/react-native-renderer/src/ReactNativeAttributePayloadFabric.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
1515
import isArray from 'shared/isArray';
1616

17-
import {enableEarlyReturnForPropDiffing} from 'shared/ReactFeatureFlags';
1817
import {enableAddPropertiesFastPath} from 'shared/ReactFeatureFlags';
1918

2019
import type {AttributeConfiguration} from './ReactNativeTypes';
@@ -551,11 +550,6 @@ export function diff(
551550
nextProps: Object,
552551
validAttributes: AttributeConfiguration,
553552
): null | Object {
554-
if (enableEarlyReturnForPropDiffing) {
555-
if (prevProps === nextProps) {
556-
return null; // no change
557-
}
558-
}
559553
return diffProperties(
560554
null, // updatePayload
561555
prevProps,

packages/shared/ReactFeatureFlags.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ export const passChildrenWhenCloningPersistedNodes = false;
121121

122122
export const enableServerComponentLogs = __EXPERIMENTAL__;
123123

124-
export const enableEarlyReturnForPropDiffing = false;
125-
126124
export const enableAddPropertiesFastPath = false;
127125

128126
export const enableOwnerStacks = __EXPERIMENTAL__;

packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export const disableDefaultPropsExceptForClasses = __VARIANT__;
2323
export const disableStringRefs = __VARIANT__;
2424
export const enableAddPropertiesFastPath = __VARIANT__;
2525
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
26-
export const enableEarlyReturnForPropDiffing = __VARIANT__;
2726
export const enableFastJSX = __VARIANT__;
2827
export const enableInfiniteRenderLoopDetection = __VARIANT__;
2928
export const enableRefAsProp = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export const {
2525
disableStringRefs,
2626
enableAddPropertiesFastPath,
2727
enableDeferRootSchedulingToMicrotask,
28-
enableEarlyReturnForPropDiffing,
2928
enableFastJSX,
3029
enableInfiniteRenderLoopDetection,
3130
enableRefAsProp,

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export const allowConcurrentByDefault = false;
101101
export const enableTransitionTracing = false;
102102
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
103103
export const passChildrenWhenCloningPersistedNodes = false;
104-
export const enableEarlyReturnForPropDiffing = false;
105104
export const enableAsyncIterableChildren = false;
106105
export const enableAddPropertiesFastPath = false;
107106

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ export const disableClientCache = true;
7676

7777
export const enableServerComponentLogs = true;
7878
export const enableInfiniteRenderLoopDetection = false;
79-
export const enableEarlyReturnForPropDiffing = false;
8079
export const enableAddPropertiesFastPath = false;
8180

8281
export const renameElementSymbol = true;

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ export const disableLegacyMode = false;
8888
export const disableDOMTestUtils = false;
8989

9090
export const disableDefaultPropsExceptForClasses = false;
91-
export const enableEarlyReturnForPropDiffing = false;
9291
export const enableAddPropertiesFastPath = false;
9392

9493
export const renameElementSymbol = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ export const disableLegacyMode = false;
8888
export const disableDOMTestUtils = false;
8989

9090
export const disableDefaultPropsExceptForClasses = false;
91-
export const enableEarlyReturnForPropDiffing = false;
9291
export const enableAddPropertiesFastPath = false;
9392

9493
export const renameElementSymbol = false;

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ export const disableStringRefs = false;
121121
export const disableLegacyMode = __EXPERIMENTAL__;
122122

123123
export const disableDOMTestUtils = false;
124-
export const enableEarlyReturnForPropDiffing = false;
125124

126125
export const enableOwnerStacks = false;
127126

0 commit comments

Comments
 (0)