Skip to content

Commit fa3feba

Browse files
authored
Fix prelease workflows for dry: false (#33582)
## Summary Follow-up to #33525 Fixes `Unsupported tag: "false"` (https://github.com/facebook/react/actions/runs/15773778995/job/44463562733#step:13:12) which also affects nightly releases. ## How did you test this change? - [x] Run successful, manual prerelease from this branch: https://github.com/facebook/react/actions/runs/15774083406
1 parent 2a911f2 commit fa3feba

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/runtime_prereleases.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
--skipTests \
8686
--tags=${{ inputs.dist_tag }} \
8787
--onlyPackages=${{ inputs.only_packages }} ${{ (inputs.dry && '') || '\'}}
88-
${{ inputs.dry && '--dry'}}
88+
${{ inputs.dry && '--dry' || '' }}
8989
- if: '${{ inputs.skip_packages }}'
9090
name: 'Publish all packages EXCEPT ${{ inputs.skip_packages }}'
9191
run: |
@@ -94,14 +94,14 @@ jobs:
9494
--skipTests \
9595
--tags=${{ inputs.dist_tag }} \
9696
--skipPackages=${{ inputs.skip_packages }} ${{ (inputs.dry && '') || '\'}}
97-
${{ inputs.dry && '--dry'}}
97+
${{ inputs.dry && '--dry' || '' }}
9898
- if: '${{ !(inputs.skip_packages && inputs.only_packages) }}'
9999
name: 'Publish all packages'
100100
run: |
101101
scripts/release/publish.js \
102102
--ci \
103103
--tags=${{ inputs.dist_tag }} ${{ (inputs.dry && '') || '\'}}
104-
${{ inputs.dry && '--dry'}}
104+
${{ inputs.dry && '--dry' || '' }}
105105
- name: Notify Discord on failure
106106
if: failure() && inputs.enableFailureNotification == true
107107
uses: tsickert/discord-webhook@86dc739f3f165f16dadc5666051c367efa1692f4

.github/workflows/runtime_releases_from_npm_manual.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
--tags=${{ inputs.tags }} \
111111
--publishVersion=${{ inputs.version_to_publish }} \
112112
--onlyPackages=${{ inputs.only_packages }} ${{ (inputs.dry && '') || '\'}}
113-
${{ inputs.dry && '--dry'}}
113+
${{ inputs.dry && '--dry' || '' }}
114114
- if: '${{ inputs.skip_packages }}'
115115
name: 'Publish all packages EXCEPT ${{ inputs.skip_packages }}'
116116
run: |
@@ -119,7 +119,7 @@ jobs:
119119
--tags=${{ inputs.tags }} \
120120
--publishVersion=${{ inputs.version_to_publish }} \
121121
--skipPackages=${{ inputs.skip_packages }} ${{ (inputs.dry && '') || '\'}}
122-
${{ inputs.dry && '--dry'}}
122+
${{ inputs.dry && '--dry' || '' }}
123123
- name: Archive released package for debugging
124124
uses: actions/upload-artifact@v4
125125
with:

0 commit comments

Comments
 (0)