Flow: remove unused suppressions (#25424)

Removes $FlowFixMe's that are no longer needed.

Used flow/tool from the Flow repo:

```
 ~/Developer/flow/tool update-suppressions .
```

Author: kassens

packages/react-cache/src/ReactCacheOld.js

@@ -122,7 +122,6 @@ function accessResult<I, K, V>(
     );
     const newResult: PendingResult = {
       status: Pending,
-      // $FlowFixMe[method-unbinding]
       value: thenable,
     };
     // $FlowFixMe[escaped-generic] discovered when updating Flow

packages/react-client/src/ReactFlightClient.js

@@ -321,7 +321,6 @@ function initializeModelChunk<T>(chunk: ResolvedModelChunk<T>): void {
       initializingChunkBlockedModel !== null &&
       initializingChunkBlockedModel.deps > 0
     ) {
-      // $FlowFixMe[incompatible-type]: found when upgrading Flow
       initializingChunkBlockedModel.value = value;
       // We discovered new dependencies on modules that are not yet resolved.
       // We have to go the BLOCKED state until they're resolved.

packages/react-devtools-shared/src/backend/NativeStyleEditor/setupNativeStyleEditor.js

@@ -129,7 +129,6 @@ function measureStyle(
     return;
   }
 
-  // $FlowFixMe the parameter types of an unknown function are unknown
   instance.measure((x, y, width, height, left, top) => {
     // RN Android sometimes returns undefined here. Don't send measurements in this case.
     // https://github.com/jhen0409/react-native-debugger/issues/84#issuecomment-304611817

packages/react-devtools-shared/src/backend/console.js

@@ -181,7 +181,6 @@ export function patch({
     unpatchFn = () => {
       for (const method in originalConsoleMethods) {
         try {
-          // $FlowFixMe property error|warn is not writable.
           targetConsole[method] = originalConsoleMethods[method];
         } catch (error) {}
       }
@@ -279,7 +278,6 @@ export function patch({
         overrideMethod.__REACT_DEVTOOLS_ORIGINAL_METHOD__ = originalMethod;
         originalMethod.__REACT_DEVTOOLS_OVERRIDE_METHOD__ = overrideMethod;
 
-        // $FlowFixMe property error|warn is not writable.
         targetConsole[method] = overrideMethod;
       } catch (error) {}
     });
@@ -321,7 +319,6 @@ export function patchForStrictMode() {
     unpatchForStrictModeFn = () => {
       for (const method in originalConsoleMethods) {
         try {
-          // $FlowFixMe property error|warn is not writable.
           targetConsole[method] = originalConsoleMethods[method];
         } catch (error) {}
       }
@@ -355,7 +352,6 @@ export function patchForStrictMode() {
         overrideMethod.__REACT_DEVTOOLS_STRICT_MODE_ORIGINAL_METHOD__ = originalMethod;
         originalMethod.__REACT_DEVTOOLS_STRICT_MODE_OVERRIDE_METHOD__ = overrideMethod;
 
-        // $FlowFixMe property error|warn is not writable.
         targetConsole[method] = overrideMethod;
       } catch (error) {}
     });

packages/react-devtools-shared/src/backend/profilingHooks.js

@@ -53,7 +53,6 @@ let supportsUserTimingV3 = false;
 if (supportsUserTiming) {
   const CHECK_V3_MARK = '__v3';
   const markOptions = {};
-  // $FlowFixMe: Ignore Flow complaining about needing a value
   Object.defineProperty(markOptions, 'startTime', {
     get: function() {
       supportsUserTimingV3 = true;

packages/react-devtools-shared/src/backend/renderer.js

@@ -387,7 +387,6 @@ export function getInternalReactConstants(
     const symbolOrNumber =
       typeof type === 'object' && type !== null ? type.$$typeof : type;
 
-    // $FlowFixMe Flow doesn't know about typeof "symbol"
     return typeof symbolOrNumber === 'symbol'
       ? // $FlowFixMe `toString()` doesn't match the type signature?
         symbolOrNumber.toString()
@@ -3275,7 +3274,6 @@ export function attach(
       for (const method in console) {
         try {
           originalConsoleMethods[method] = console[method];
-          // $FlowFixMe property error|warn is not writable.
           console[method] = () => {};
         } catch (error) {}
       }
@@ -3290,7 +3288,6 @@ export function attach(
         // Restore original console functionality.
         for (const method in originalConsoleMethods) {
           try {
-            // $FlowFixMe property error|warn is not writable.
             console[method] = originalConsoleMethods[method];
           } catch (error) {}
         }
@@ -3713,7 +3710,6 @@ export function attach(
       id,
       responseID: requestID,
       type: 'full-data',
-      // $FlowFixMe[incompatible-return] found when upgrading Flow
       // $FlowFixMe[prop-missing] found when upgrading Flow
       value: cleanedInspectedElement,
     };

packages/react-devtools-shared/src/backend/views/Highlighter/index.js

@@ -119,7 +119,6 @@ export default function setupHighlighter(
       if (scrollIntoView && typeof node.scrollIntoView === 'function') {
         // If the node isn't visible show it before highlighting it.
         // We may want to reconsider this; it might be a little disruptive.
-        // $FlowFixMe Flow only knows about 'start' | 'end'
         node.scrollIntoView({block: 'nearest', inline: 'nearest'});
       }
 

packages/react-devtools-shared/src/devtools/cache.js

@@ -128,7 +128,6 @@ function accessResult<Input, Key, Value>(
     );
     const newResult: PendingResult = {
       status: Pending,
-      // $FlowFixMe[method-unbinding]
       value: thenable,
     };
     entriesForResource.set(key, newResult);

packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js

@@ -138,7 +138,6 @@ export function InnerHooksTreeView({
   inspectedElement,
   path,
 }: InnerHooksTreeViewProps): React.Node {
-  // $FlowFixMe "Missing type annotation for U" whatever that means
   return hooks.map((hook, index) => (
     <HookView
       key={index}
@@ -356,7 +355,6 @@ function HookView({
               className={name !== '' ? styles.Name : styles.NameAnonymous}>
               {hookDisplayName || 'Anonymous'}
             </span>{' '}
-            {/* $FlowFixMe */}
             <span className={styles.Value} onClick={toggleIsOpen}>
               {displayValue}
             </span>

packages/react-devtools-shared/src/devtools/views/Components/Tree.js

@@ -409,7 +409,6 @@ export default function Tree(props: Props): React.Node {
           tabIndex={0}>
           <AutoSizer>
             {({height, width}) => (
-              // $FlowFixMe https://github.com/facebook/flow/issues/7341
               <FixedSizeList
                 className={styles.List}
                 height={height}