Stub host config methods to suspend commit phase

This adds some new methods to the host config, but does not implement
them yet. The purpose of these methods will be to allow the renderer to
suspend right the commit phase without suspending render, like to wait
for CSS to load before updating the screen. More context will be given
subsequent steps.

I didn't follow the `supportsHydration` pattern for optional host config
methods because this feature seems pretty generally useful to any
renderer, and declaring a no-op implementation is trivial.

I didn't update the docs for react-reconciler yet because this very
likely isn't the final layering. I'll document once the contract has
stablized more.

Author: acdlite

packages/react-art/src/ReactARTHostConfig.js

@@ -459,6 +459,18 @@ export function requestPostPaintCallback(callback: (time: number) => void) {
   // noop
 }
 
+export function shouldSuspendMount(instance, type, newProps) {
+  return null;
+}
+
+export function shouldSuspendUpdate(instance, type, oldProps, newProps) {
+  return null;
+}
+
+export function waitForCommitToBeReady(suspenseyThings) {
+  return null;
+}
+
 // eslint-disable-next-line no-undef
 export function prepareRendererToRender(container: Container): void {
   // noop

packages/react-dom-bindings/src/client/ReactDOMHostConfig.js

@@ -156,6 +156,7 @@ export type ChildSet = void; // Unused
 export type TimeoutHandle = TimeoutID;
 export type NoTimeout = -1;
 export type RendererInspectionConfig = $ReadOnly<{}>;
+export type SuspendCommitPayload = null;
 
 type SelectionInformation = {
   focusedElem: null | HTMLElement,
@@ -1608,6 +1609,30 @@ export function requestPostPaintCallback(callback: (time: number) => void) {
     localRequestAnimationFrame(time => callback(time));
   });
 }
+
+export function shouldSuspendMount(
+  instance: Instance,
+  type: string,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function shouldSuspendUpdate(
+  instance: Instance,
+  type: string,
+  oldProps: Props,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function waitForCommitToBeReady(
+  suspenseyThings: Array<SuspendCommitPayload> | null,
+): null {
+  return null;
+}
+
 // -------------------
 //     Resources
 // -------------------

packages/react-native-renderer/src/ReactFabricHostConfig.js

@@ -87,6 +87,8 @@ export type RendererInspectionConfig = $ReadOnly<{
   ) => void,
 }>;
 
+export type SuspendCommitPayload = null;
+
 // TODO: Remove this conditional once all changes have propagated.
 if (registerEventHandler) {
   /**
@@ -418,6 +420,29 @@ export function requestPostPaintCallback(callback: (time: number) => void) {
   // noop
 }
 
+export function shouldSuspendMount(
+  instance: Instance,
+  type: string,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function shouldSuspendUpdate(
+  instance: Instance,
+  type: string,
+  oldProps: Props,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function waitForCommitToBeReady(
+  suspenseyThings: Array<SuspendCommitPayload> | null,
+): null {
+  return null;
+}
+
 export function prepareRendererToRender(container: Container): void {
   // noop
 }

packages/react-native-renderer/src/ReactNativeHostConfig.js

@@ -55,6 +55,8 @@ export type RendererInspectionConfig = $ReadOnly<{
   ) => void,
 }>;
 
+export type SuspendCommitPayload = null;
+
 const UPDATE_SIGNAL = {};
 if (__DEV__) {
   Object.freeze(UPDATE_SIGNAL);
@@ -522,6 +524,29 @@ export function requestPostPaintCallback(callback: (time: number) => void) {
   // noop
 }
 
+export function shouldSuspendMount(
+  instance: Instance,
+  type: string,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function shouldSuspendUpdate(
+  instance: Instance,
+  type: string,
+  oldProps: Props,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function waitForCommitToBeReady(
+  suspenseyThings: Array<SuspendCommitPayload> | null,
+): null {
+  return null;
+}
+
 export function prepareRendererToRender(container: Container): void {
   // noop
 }

packages/react-noop-renderer/src/ReactNoop.js

@@ -28,6 +28,9 @@ export const {
   createLegacyRoot,
   getChildrenAsJSX,
   getPendingChildrenAsJSX,
+  getSuspenseyThingStatus,
+  resolveSuspenseyThing,
+  resetSuspenseyThingCache,
   createPortal,
   render,
   renderLegacySyncRoot,

packages/react-noop-renderer/src/createReactNoop.js

@@ -72,6 +72,8 @@ type CreateRootOptions = {
   ...
 };
 
+type SuspendCommitPayload = string;
+
 const NO_CONTEXT = {};
 const UPPERCASE_CONTEXT = {};
 const UPDATE_SIGNAL = {};
@@ -480,6 +482,30 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
       const endTime = Scheduler.unstable_now();
       callback(endTime);
     },
+
+    shouldSuspendMount(
+      instance: Instance,
+      type: string,
+      newProps: Props,
+    ): SuspendCommitPayload | null {
+      return null;
+    },
+
+    shouldSuspendUpdate(
+      instance: Instance,
+      type: string,
+      oldProps: Props,
+      newProps: Props,
+    ): SuspendCommitPayload | null {
+      return null;
+    },
+
+    waitForCommitToBeReady(
+      suspenseyThings: Array<SuspendCommitPayload> | null,
+    ): null {
+      return null;
+    },
+
     prepareRendererToRender() {},
     resetRendererAfterRender() {},
   };

packages/react-reconciler/src/__tests__/ReactFiberHostContext-test.internal.js

@@ -71,6 +71,15 @@ describe('ReactFiberHostContext', () => {
         return DefaultEventPriority;
       },
       requestPostPaintCallback: function () {},
+      shouldSuspendMount(instance, type, newProps) {
+        return null;
+      },
+      shouldSuspendUpdate(instance, type, oldProps, newProps) {
+        return null;
+      },
+      waitForCommitToBeReady(suspenseyThings) {
+        return null;
+      },
       prepareRendererToRender: function () {},
       resetRendererAfterRender: function () {},
       supportsMutation: true,

packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js

@@ -38,6 +38,7 @@ export opaque type ChildSet = mixed; // eslint-disable-line no-undef
 export opaque type TimeoutHandle = mixed; // eslint-disable-line no-undef
 export opaque type NoTimeout = mixed; // eslint-disable-line no-undef
 export opaque type RendererInspectionConfig = mixed; // eslint-disable-line no-undef
+export opaque type SuspendCommitPayload = mixed; // eslint-disable-line no-undef
 export type EventResponder = any;
 
 export const getPublicInstance = $$$hostConfig.getPublicInstance;
@@ -68,6 +69,9 @@ export const getInstanceFromScope = $$$hostConfig.getInstanceFromScope;
 export const getCurrentEventPriority = $$$hostConfig.getCurrentEventPriority;
 export const detachDeletedInstance = $$$hostConfig.detachDeletedInstance;
 export const requestPostPaintCallback = $$$hostConfig.requestPostPaintCallback;
+export const shouldSuspendMount = $$$hostConfig.shouldSuspendMount;
+export const shouldSuspendUpdate = $$$hostConfig.shouldSuspendUpdate;
+export const waitForCommitToBeReady = $$$hostConfig.waitForCommitToBeReady;
 export const prepareRendererToRender = $$$hostConfig.prepareRendererToRender;
 export const resetRendererAfterRender = $$$hostConfig.resetRendererAfterRender;
 

packages/react-test-renderer/src/ReactTestHostConfig.js

@@ -42,6 +42,8 @@ export type EventResponder = any;
 
 export type RendererInspectionConfig = $ReadOnly<{}>;
 
+export type SuspendCommitPayload = null;
+
 export * from 'react-reconciler/src/ReactFiberHostConfigWithNoPersistence';
 export * from 'react-reconciler/src/ReactFiberHostConfigWithNoHydration';
 export * from 'react-reconciler/src/ReactFiberHostConfigWithNoTestSelectors';
@@ -324,6 +326,29 @@ export function requestPostPaintCallback(callback: (time: number) => void) {
   // noop
 }
 
+export function shouldSuspendMount(
+  instance: Instance,
+  type: string,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function shouldSuspendUpdate(
+  instance: Instance,
+  type: string,
+  oldProps: Props,
+  newProps: Props,
+): SuspendCommitPayload | null {
+  return null;
+}
+
+export function waitForCommitToBeReady(
+  suspenseyThings: Array<SuspendCommitPayload> | null,
+): null {
+  return null;
+}
+
 export function prepareRendererToRender(container: Container): void {
   // noop
 }