Update

[ghstack-poisoned]

Author: poteto

.eslintrc.js

@@ -17,6 +17,8 @@ module.exports = {
   // Stop ESLint from looking for a configuration file in parent folders
   root: true,
 
+  reportUnusedDisableDirectives: true,
+
   plugins: [
     'babel',
     'ft-flow',

packages/react-client/src/ReactFlightClient.js

@@ -1839,7 +1839,6 @@ function resolveHint<Code: HintCode>(
   dispatchHint(code, hintModel);
 }
 
-// eslint-disable-next-line react-internal/no-production-logging
 const supportsCreateTask =
   __DEV__ && enableOwnerStacks && !!(console: any).createTask;
 
@@ -1977,7 +1976,6 @@ function initializeFakeTask(
       ? null
       : initializeFakeTask(response, componentInfo.owner);
 
-  // eslint-disable-next-line react-internal/no-production-logging
   const createTaskFn = (console: any).createTask.bind(
     console,
     getServerComponentTaskName(componentInfo),

packages/react-client/src/ReactFlightReplyClient.js

@@ -227,14 +227,11 @@ export function processReply(
     function progress(entry: {done: boolean, value: ReactServerValue, ...}) {
       if (entry.done) {
         const blobId = nextPartId++;
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(formFieldPrefix + blobId, new Blob(buffer));
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(
           formFieldPrefix + streamId,
           '"$o' + blobId.toString(16) + '"',
         );
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(formFieldPrefix + streamId, 'C'); // Close signal
         pendingParts--;
         if (pendingParts === 0) {
@@ -262,7 +259,6 @@ export function processReply(
 
     function progress(entry: {done: boolean, value: ReactServerValue, ...}) {
       if (entry.done) {
-        // eslint-disable-next-line react-internal/safe-string-coercion
         data.append(formFieldPrefix + streamId, 'C'); // Close signal
         pendingParts--;
         if (pendingParts === 0) {
@@ -272,7 +268,6 @@ export function processReply(
         try {
           // $FlowFixMe[incompatible-type]: While plain JSON can return undefined we never do here.
           const partJSON: string = JSON.stringify(entry.value, resolveToJSON);
-          // eslint-disable-next-line react-internal/safe-string-coercion
           data.append(formFieldPrefix + streamId, partJSON);
           reader.read().then(progress, reject);
         } catch (x) {
@@ -326,7 +321,6 @@ export function processReply(
     ) {
       if (entry.done) {
         if (entry.value === undefined) {
-          // eslint-disable-next-line react-internal/safe-string-coercion
           data.append(formFieldPrefix + streamId, 'C'); // Close signal
         } else {
           // Unlike streams, the last value may not be undefined. If it's not
@@ -348,7 +342,6 @@ export function processReply(
         try {
           // $FlowFixMe[incompatible-type]: While plain JSON can return undefined we never do here.
           const partJSON: string = JSON.stringify(entry.value, resolveToJSON);
-          // eslint-disable-next-line react-internal/safe-string-coercion
           data.append(formFieldPrefix + streamId, partJSON);
           iterator.next().then(progress, reject);
         } catch (x) {
@@ -441,7 +434,6 @@ export function processReply(
             const partJSON = serializeModel(resolvedModel, lazyId);
             // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
             const data: FormData = formData;
-            // eslint-disable-next-line react-internal/safe-string-coercion
             data.append(formFieldPrefix + lazyId, partJSON);
             return serializeByValueID(lazyId);
           } catch (x) {
@@ -461,7 +453,6 @@ export function processReply(
                   const partJSON = serializeModel(value, lazyId);
                   // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
                   const data: FormData = formData;
-                  // eslint-disable-next-line react-internal/safe-string-coercion
                   data.append(formFieldPrefix + lazyId, partJSON);
                   pendingParts--;
                   if (pendingParts === 0) {
@@ -502,7 +493,6 @@ export function processReply(
               const partJSON = serializeModel(partValue, promiseId);
               // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
               const data: FormData = formData;
-              // eslint-disable-next-line react-internal/safe-string-coercion
               data.append(formFieldPrefix + promiseId, partJSON);
               pendingParts--;
               if (pendingParts === 0) {
@@ -784,7 +774,6 @@ export function processReply(
         }
         // The reference to this function came from the same client so we can pass it back.
         const refId = nextPartId++;
-        // eslint-disable-next-line react-internal/safe-string-coercion
         formData.set(formFieldPrefix + refId, metaDataJSON);
         return serializeServerReferenceID(refId);
       }

packages/react-client/src/forks/ReactFlightClientConfig.custom.js

@@ -42,7 +42,7 @@ export const usedWithSSR = true;
 
 export opaque type Source = mixed;
 
-export opaque type StringDecoder = mixed; // eslint-disable-line no-undef
+export opaque type StringDecoder = mixed;
 
 export const createStringDecoder = $$$config.createStringDecoder;
 export const readPartialStringChunk = $$$config.readPartialStringChunk;

packages/react-devtools-extensions/flow-typed/jest.js

@@ -146,13 +146,11 @@ type JestPromiseType = {
    * Use rejects to unwrap the reason of a rejected promise so any other
    * matcher can be chained. If the promise is fulfilled the assertion fails.
    */
-  // eslint-disable-next-line no-use-before-define
   rejects: JestExpectType,
   /**
    * Use resolves to unwrap the value of a fulfilled promise so any other
    * matcher can be chained. If the promise is rejected the assertion fails.
    */
-  // eslint-disable-next-line no-use-before-define
   resolves: JestExpectType,
 };
 
@@ -1098,10 +1096,8 @@ type JestPrettyFormatColors = {
 };
 
 type JestPrettyFormatIndent = string => string;
-// eslint-disable-next-line no-unused-vars
 type JestPrettyFormatRefs = Array<any>;
 type JestPrettyFormatPrint = any => string;
-// eslint-disable-next-line no-unused-vars
 type JestPrettyFormatStringOrNull = string | null;
 
 type JestPrettyFormatOptions = {
@@ -1112,7 +1108,6 @@ type JestPrettyFormatOptions = {
   indent: number,
   maxDepth: number,
   min: boolean,
-  // eslint-disable-next-line no-use-before-define
   plugins: JestPrettyFormatPlugins,
   printFunctionName: boolean,
   spacing: string,

packages/react-devtools-extensions/flow-typed/npm/react-test-renderer_v16.x.x.js

@@ -52,7 +52,6 @@ type TestRendererOptions = {
 };
 
 declare module 'react-test-renderer' {
-  // eslint-disable-next-line no-inner-declarations
   declare export type ReactTestRenderer = {
     toJSON(): null | ReactTestRendererJSON,
     toTree(): null | ReactTestRendererTree,

packages/react-devtools-inline/__tests__/__e2e__/utils.js

@@ -7,7 +7,6 @@ const config = require('../../playwright.config');
 const {test} = require('@playwright/test');
 
 function runOnlyForReactRange(range) {
-  // eslint-disable-next-line jest/no-disabled-tests
   test.skip(
     !semver.satisfies(config.use.react_version, range),
     `This test requires a React version of ${range} to run. ` +

packages/react-devtools-shared/src/__tests__/inspectedElement-test.js

@@ -665,7 +665,6 @@ describe('InspectedElement', () => {
           anonymous_fn={instance.anonymousFunction}
           array_buffer={arrayBuffer}
           array_of_arrays={arrayOfArrays}
-          // eslint-disable-next-line no-undef
           big_int={BigInt(123)}
           bound_fn={exampleFunction.bind(this)}
           data_view={dataView}
@@ -1876,7 +1875,7 @@ describe('InspectedElement', () => {
         xyz: 1,
       },
     });
-    const bigInt = BigInt(123); // eslint-disable-line no-undef
+    const bigInt = BigInt(123);
 
     await utils.actAsync(() =>
       render(

packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js

@@ -185,7 +185,6 @@ describe('InspectedElementContext', () => {
           anonymous_fn: instance.anonymousFunction,
           array_buffer: arrayBuffer,
           array_of_arrays: arrayOfArrays,
-          // eslint-disable-next-line no-undef
           big_int: BigInt(123),
           bound_fn: exampleFunction.bind(this),
           data_view: dataView,
@@ -888,7 +887,7 @@ describe('InspectedElementContext', () => {
         xyz: 1,
       },
     });
-    const bigInt = BigInt(123); // eslint-disable-line no-undef
+    const bigInt = BigInt(123);
 
     act(() =>
       ReactDOM.render(

packages/react-devtools-shared/src/backend/DevToolsConsolePatching.js

@@ -30,7 +30,6 @@ disabledLog.__reactDisabledLog = true;
 
 export function disableLogs(): void {
   if (disabledDepth === 0) {
-    /* eslint-disable react-internal/no-production-logging */
     prevLog = console.log;
     prevInfo = console.info;
     prevWarn = console.warn;
@@ -63,7 +62,6 @@ export function disableLogs(): void {
 export function reenableLogs(): void {
   disabledDepth--;
   if (disabledDepth === 0) {
-    /* eslint-disable react-internal/no-production-logging */
     const props = {
       configurable: true,
       enumerable: true,