Skip to content

Commit d462787

Browse files
tyao1rickhanlonii
authored andcommitted
[DevTools] Add events necessary for click to inspect on RN (#25111)
* Add inspectingNative events for RN * Enable inspection toggle UI for RN * Add a stopInspectingNative method for agent
1 parent 7b8c6a7 commit d462787

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

packages/react-devtools-core/src/standalone.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ function initialize(socket: WebSocket) {
256256

257257
store = new Store(bridge, {
258258
checkBridgeProtocolCompatibility: true,
259-
supportsNativeInspection: false,
259+
supportsNativeInspection: true,
260260
});
261261

262262
log('Connected');

packages/react-devtools-shared/src/backend/agent.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ type PersistedSelection = {|
144144
export default class Agent extends EventEmitter<{|
145145
hideNativeHighlight: [],
146146
showNativeHighlight: [NativeType],
147+
startInspectingNative: [],
148+
stopInspectingNative: [],
147149
shutdown: [],
148150
traceUpdates: [Set<NativeType>],
149151
|}> {
@@ -655,6 +657,10 @@ export default class Agent extends EventEmitter<{|
655657
this._bridge.send('profilingStatus', this._isProfiling);
656658
};
657659

660+
stopInspectingNative = (selected: boolean) => {
661+
this._bridge.send('stopInspectingNative', selected);
662+
};
663+
658664
storeAsGlobal = ({count, id, path, rendererID}: StoreAsGlobalParams) => {
659665
const renderer = this._rendererInterfaces[rendererID];
660666
if (renderer == null) {

packages/react-devtools-shared/src/backend/views/Highlighter/index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ export default function setupHighlighter(
4848
window.addEventListener('pointerdown', onPointerDown, true);
4949
window.addEventListener('pointerover', onPointerOver, true);
5050
window.addEventListener('pointerup', onPointerUp, true);
51+
} else {
52+
agent.emit('startInspectingNative');
5153
}
5254
}
5355

@@ -74,6 +76,8 @@ export default function setupHighlighter(
7476
window.removeEventListener('pointerdown', onPointerDown, true);
7577
window.removeEventListener('pointerover', onPointerOver, true);
7678
window.removeEventListener('pointerup', onPointerUp, true);
79+
} else {
80+
agent.emit('stopInspectingNative');
7781
}
7882
}
7983

0 commit comments

Comments
 (0)