Skip to content

Commit d094ee1

Browse files
committed
[Fizz][Static] when aborting a prerender halt unfinished boundaries instead of erroring (#30732)
When we introduced prerendering for flight we modeled an abort of a flight prerender as having unfinished rows. This is similar to how postpone was already implemented when you postponed from "within" a prerender using React.unstable_postpone. However when aborting with a postponed instance every boundary would be eagerly marked for client rendering which is more akin to prerendering and then resuming with an aborted signal. The insight with the flight work was that it's not so much the postpone that describes the intended semantics but the abort combined with a prerender. So like in flight when you abort a prerender and enableHalt is enabled boundaries and the shell won't error for any reason. Fizz will still call onPostpone and onError according to the abort reason but the consuemr of the prerender should expect to resume it before trying to use it. DiffTrain build for [85180b8](85180b8)
1 parent 7420875 commit d094ee1

36 files changed

+98
-92
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2505bf9b3400c6a00381e86d30b495935f5339df
1+
85180b8cf84274795986c8f2c8473f8816db8b7b
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2505bf9b3400c6a00381e86d30b495935f5339df
1+
85180b8cf84274795986c8f2c8473f8816db8b7b

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2001,7 +2001,7 @@ __DEV__ &&
20012001
exports.useTransition = function () {
20022002
return resolveDispatcher().useTransition();
20032003
};
2004-
exports.version = "19.0.0-www-classic-2505bf9b-20240820";
2004+
exports.version = "19.0.0-www-classic-85180b8c-20240820";
20052005
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20062006
"function" ===
20072007
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1981,7 +1981,7 @@ __DEV__ &&
19811981
exports.useTransition = function () {
19821982
return resolveDispatcher().useTransition();
19831983
};
1984-
exports.version = "19.0.0-www-modern-2505bf9b-20240820";
1984+
exports.version = "19.0.0-www-modern-85180b8c-20240820";
19851985
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19861986
"function" ===
19871987
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-2505bf9b-20240820";
668+
exports.version = "19.0.0-www-classic-85180b8c-20240820";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-2505bf9b-20240820";
668+
exports.version = "19.0.0-www-modern-85180b8c-20240820";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-2505bf9b-20240820";
672+
exports.version = "19.0.0-www-classic-85180b8c-20240820";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-2505bf9b-20240820";
672+
exports.version = "19.0.0-www-modern-85180b8c-20240820";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16776,11 +16776,11 @@ __DEV__ &&
1677616776
(function () {
1677716777
var internals = {
1677816778
bundleType: 1,
16779-
version: "19.0.0-www-classic-2505bf9b-20240820",
16779+
version: "19.0.0-www-classic-85180b8c-20240820",
1678016780
rendererPackageName: "react-art",
1678116781
currentDispatcherRef: ReactSharedInternals,
1678216782
findFiberByHostInstance: getInstanceFromNode,
16783-
reconcilerVersion: "19.0.0-www-classic-2505bf9b-20240820"
16783+
reconcilerVersion: "19.0.0-www-classic-85180b8c-20240820"
1678416784
};
1678516785
internals.overrideHookState = overrideHookState;
1678616786
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16814,7 +16814,7 @@ __DEV__ &&
1681416814
exports.Shape = Shape;
1681516815
exports.Surface = Surface;
1681616816
exports.Text = Text;
16817-
exports.version = "19.0.0-www-classic-2505bf9b-20240820";
16817+
exports.version = "19.0.0-www-classic-85180b8c-20240820";
1681816818
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1681916819
"function" ===
1682016820
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16189,11 +16189,11 @@ __DEV__ &&
1618916189
(function () {
1619016190
var internals = {
1619116191
bundleType: 1,
16192-
version: "19.0.0-www-modern-2505bf9b-20240820",
16192+
version: "19.0.0-www-modern-85180b8c-20240820",
1619316193
rendererPackageName: "react-art",
1619416194
currentDispatcherRef: ReactSharedInternals,
1619516195
findFiberByHostInstance: getInstanceFromNode,
16196-
reconcilerVersion: "19.0.0-www-modern-2505bf9b-20240820"
16196+
reconcilerVersion: "19.0.0-www-modern-85180b8c-20240820"
1619716197
};
1619816198
internals.overrideHookState = overrideHookState;
1619916199
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16227,7 +16227,7 @@ __DEV__ &&
1622716227
exports.Shape = Shape;
1622816228
exports.Surface = Surface;
1622916229
exports.Text = Text;
16230-
exports.version = "19.0.0-www-modern-2505bf9b-20240820";
16230+
exports.version = "19.0.0-www-modern-85180b8c-20240820";
1623116231
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1623216232
"function" ===
1623316233
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)