Skip to content

Commit cd1070e

Browse files
committed
Fix assertConsoleErrorDev on message mismatch with withoutStack: true
1 parent 0315897 commit cd1070e

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

packages/internal-test-utils/__tests__/ReactInternalTestUtils-test.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2426,7 +2426,17 @@ describe('ReactInternalTestUtils console assertions', () => {
24262426
],
24272427
]);
24282428
});
2429-
expect(message).toMatchInlineSnapshot(`"message.replace is not a function"`);
2429+
expect(message).toMatchInlineSnapshot(`
2430+
"assertConsoleErrorDev(expected)
2431+
2432+
Unexpected error(s) recorded.
2433+
2434+
- Expected errors
2435+
+ Received errors
2436+
2437+
- Hello
2438+
+ Bye <component stack>"
2439+
`);
24302440
});
24312441
});
24322442

packages/internal-test-utils/consoleMock.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,12 @@ export function createLogAssertion(
464464
function printDiff() {
465465
return `${diff(
466466
expectedMessages
467-
.map(message => message.replace('\n', ' '))
467+
.map(messageOrTuple => {
468+
const message = Array.isArray(messageOrTuple)
469+
? messageOrTuple[0]
470+
: messageOrTuple;
471+
return message.replace('\n', ' ');
472+
})
468473
.join('\n'),
469474
receivedLogs.map(message => message.replace('\n', ' ')).join('\n'),
470475
{

0 commit comments

Comments
 (0)