Skip to content

Commit 79bcf6e

Browse files
committed
Fix missing trailing / in commit artifacts workflow
The trailing / was being omitted, so instead of moving the cjs directory itself, it would move only its contents instead. This broke some internal path assumptions. Additionally, updates the step to create the react-dom directory prior to moving. ghstack-source-id: b6eedb0 Pull Request resolved: #31026
1 parent 4e9540e commit 79bcf6e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/runtime_commit_artifacts.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,14 @@ jobs:
118118
run: |
119119
BASE_FOLDER='compiled-rn/facebook-fbsource/xplat/js'
120120
mkdir -p ${BASE_FOLDER}/react-native-github/Libraries/Renderer/
121-
mkdir -p ${BASE_FOLDER}/RKJSModules/vendor/react/{scheduler,react,react-is,react-test-renderer}/
121+
mkdir -p ${BASE_FOLDER}/RKJSModules/vendor/react/{scheduler,react,react-dom,react-is,react-test-renderer}/
122122
123123
# Move React Native renderer
124124
mv build/react-native/implementations/ $BASE_FOLDER/react-native-github/Libraries/Renderer/
125125
mv build/react-native/shims/ $BASE_FOLDER/react-native-github/Libraries/Renderer/
126126
mv build/facebook-react-native/scheduler/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/scheduler/
127127
mv build/facebook-react-native/react/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react/
128-
mv build/facebook-react-native/react-dom/cjs $BASE_FOLDER/RKJSModules/vendor/react/react-dom/
128+
mv build/facebook-react-native/react-dom/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-dom/
129129
mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
130130
mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
131131

0 commit comments

Comments
 (0)