Skip to content

Commit 7609723

Browse files
committed
Move schedulerPriorityToLanePriority
1 parent 3b739ec commit 7609723

File tree

3 files changed

+35
-47
lines changed

3 files changed

+35
-47
lines changed

packages/react-dom/src/events/ReactDOMEventListener.js

Lines changed: 35 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@
88
*/
99

1010
import type {AnyNativeEvent} from '../events/PluginModuleType';
11-
import type {FiberRoot} from 'react-reconciler/src/ReactInternalTypes';
11+
import type {
12+
FiberRoot,
13+
ReactPriorityLevel,
14+
} from 'react-reconciler/src/ReactInternalTypes';
1215
import type {Container, SuspenseInstance} from '../client/ReactDOMHostConfig';
1316
import type {DOMEventName} from '../events/DOMEventNames';
1417

@@ -50,18 +53,27 @@ import {
5053
DefaultLanePriority as DefaultLanePriority_old,
5154
getCurrentUpdateLanePriority as getCurrentUpdateLanePriority_old,
5255
setCurrentUpdateLanePriority as setCurrentUpdateLanePriority_old,
53-
schedulerPriorityToLanePriority as schedulerPriorityToLanePriority_old,
5456
} from 'react-reconciler/src/ReactFiberLane.old';
5557
import {
5658
InputDiscreteLanePriority as InputDiscreteLanePriority_new,
5759
InputContinuousLanePriority as InputContinuousLanePriority_new,
5860
DefaultLanePriority as DefaultLanePriority_new,
5961
getCurrentUpdateLanePriority as getCurrentUpdateLanePriority_new,
6062
setCurrentUpdateLanePriority as setCurrentUpdateLanePriority_new,
61-
schedulerPriorityToLanePriority as schedulerPriorityToLanePriority_new,
63+
SyncLanePriority,
64+
IdleLanePriority,
65+
NoLanePriority,
6266
} from 'react-reconciler/src/ReactFiberLane.new';
6367
import {getCurrentPriorityLevel as getCurrentPriorityLevel_old} from 'react-reconciler/src/SchedulerWithReactIntegration.old';
64-
import {getCurrentPriorityLevel as getCurrentPriorityLevel_new} from 'react-reconciler/src/SchedulerWithReactIntegration.new';
68+
import {
69+
getCurrentPriorityLevel as getCurrentPriorityLevel_new,
70+
IdlePriority as IdleSchedulerPriority,
71+
ImmediatePriority as ImmediateSchedulerPriority,
72+
LowPriority as LowSchedulerPriority,
73+
NormalPriority as NormalSchedulerPriority,
74+
UserBlockingPriority as UserBlockingSchedulerPriority,
75+
} from 'react-reconciler/src/SchedulerWithReactIntegration.new';
76+
import type {LanePriority} from 'react-reconciler/src/ReactFiberLane.new';
6577

6678
const InputDiscreteLanePriority = enableNewReconciler
6779
? InputDiscreteLanePriority_new
@@ -78,13 +90,29 @@ const getCurrentUpdateLanePriority = enableNewReconciler
7890
const setCurrentUpdateLanePriority = enableNewReconciler
7991
? setCurrentUpdateLanePriority_new
8092
: setCurrentUpdateLanePriority_old;
81-
const schedulerPriorityToLanePriority = enableNewReconciler
82-
? schedulerPriorityToLanePriority_new
83-
: schedulerPriorityToLanePriority_old;
8493
const getCurrentPriorityLevel = enableNewReconciler
8594
? getCurrentPriorityLevel_new
8695
: getCurrentPriorityLevel_old;
8796

97+
function schedulerPriorityToLanePriority(
98+
schedulerPriorityLevel: ReactPriorityLevel,
99+
): LanePriority {
100+
switch (schedulerPriorityLevel) {
101+
case ImmediateSchedulerPriority:
102+
return SyncLanePriority;
103+
case UserBlockingSchedulerPriority:
104+
return InputContinuousLanePriority;
105+
case NormalSchedulerPriority:
106+
case LowSchedulerPriority:
107+
// TODO: Handle LowSchedulerPriority, somehow. Maybe the same lane as hydration.
108+
return DefaultLanePriority;
109+
case IdleSchedulerPriority:
110+
return IdleLanePriority;
111+
default:
112+
return NoLanePriority;
113+
}
114+
}
115+
88116
// TODO: can we stop exporting these?
89117
export let _enabled = true;
90118

packages/react-reconciler/src/ReactFiberLane.new.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import {
4242
ImmediatePriority as ImmediateSchedulerPriority,
4343
UserBlockingPriority as UserBlockingSchedulerPriority,
4444
NormalPriority as NormalSchedulerPriority,
45-
LowPriority as LowSchedulerPriority,
4645
IdlePriority as IdleSchedulerPriority,
4746
NoPriority as NoSchedulerPriority,
4847
} from './SchedulerWithReactIntegration.new';
@@ -275,25 +274,6 @@ function getHighestPriorityLanes(lanes: Lanes | Lane): Lanes {
275274
}
276275
}
277276

278-
export function schedulerPriorityToLanePriority(
279-
schedulerPriorityLevel: ReactPriorityLevel,
280-
): LanePriority {
281-
switch (schedulerPriorityLevel) {
282-
case ImmediateSchedulerPriority:
283-
return SyncLanePriority;
284-
case UserBlockingSchedulerPriority:
285-
return InputContinuousLanePriority;
286-
case NormalSchedulerPriority:
287-
case LowSchedulerPriority:
288-
// TODO: Handle LowSchedulerPriority, somehow. Maybe the same lane as hydration.
289-
return DefaultLanePriority;
290-
case IdleSchedulerPriority:
291-
return IdleLanePriority;
292-
default:
293-
return NoLanePriority;
294-
}
295-
}
296-
297277
export function lanePriorityToSchedulerPriority(
298278
lanePriority: LanePriority,
299279
): ReactPriorityLevel {

packages/react-reconciler/src/ReactFiberLane.old.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import {
4242
ImmediatePriority as ImmediateSchedulerPriority,
4343
UserBlockingPriority as UserBlockingSchedulerPriority,
4444
NormalPriority as NormalSchedulerPriority,
45-
LowPriority as LowSchedulerPriority,
4645
IdlePriority as IdleSchedulerPriority,
4746
NoPriority as NoSchedulerPriority,
4847
} from './SchedulerWithReactIntegration.old';
@@ -275,25 +274,6 @@ function getHighestPriorityLanes(lanes: Lanes | Lane): Lanes {
275274
}
276275
}
277276

278-
export function schedulerPriorityToLanePriority(
279-
schedulerPriorityLevel: ReactPriorityLevel,
280-
): LanePriority {
281-
switch (schedulerPriorityLevel) {
282-
case ImmediateSchedulerPriority:
283-
return SyncLanePriority;
284-
case UserBlockingSchedulerPriority:
285-
return InputContinuousLanePriority;
286-
case NormalSchedulerPriority:
287-
case LowSchedulerPriority:
288-
// TODO: Handle LowSchedulerPriority, somehow. Maybe the same lane as hydration.
289-
return DefaultLanePriority;
290-
case IdleSchedulerPriority:
291-
return IdleLanePriority;
292-
default:
293-
return NoLanePriority;
294-
}
295-
}
296-
297277
export function lanePriorityToSchedulerPriority(
298278
lanePriority: LanePriority,
299279
): ReactPriorityLevel {

0 commit comments

Comments
 (0)