Skip to content

Commit 605b7c0

Browse files
authored
Concurrent rendering in ReactDevToolsHooksIntegration-test (#28522)
## Summary We need to unblock flipping the default for RTR to be concurrent rendering. Update ReactDevToolsHooksIntegration-test to use `unstable_isConcurrent` in place. ## How did you test this change? `yarn test packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js`
1 parent 56e2005 commit 605b7c0

File tree

1 file changed

+31
-14
lines changed

1 file changed

+31
-14
lines changed

packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js

Lines changed: 31 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('React hooks DevTools integration', () => {
4343
const InternalTestUtils = require('internal-test-utils');
4444
waitForAll = InternalTestUtils.waitForAll;
4545

46-
act = ReactTestRenderer.act;
46+
act = require('internal-test-utils').act;
4747
});
4848

4949
it('should support editing useState hooks', async () => {
@@ -55,7 +55,12 @@ describe('React hooks DevTools integration', () => {
5555
return <div>count:{count}</div>;
5656
}
5757

58-
const renderer = ReactTestRenderer.create(<MyComponent />);
58+
let renderer;
59+
await act(() => {
60+
renderer = ReactTestRenderer.create(<MyComponent />, {
61+
unstable_isConcurrent: true,
62+
});
63+
});
5964
expect(renderer.toJSON()).toEqual({
6065
type: 'div',
6166
props: {},
@@ -107,7 +112,12 @@ describe('React hooks DevTools integration', () => {
107112
);
108113
}
109114

110-
const renderer = ReactTestRenderer.create(<MyComponent />);
115+
let renderer;
116+
await act(() => {
117+
renderer = ReactTestRenderer.create(<MyComponent />, {
118+
unstable_isConcurrent: true,
119+
});
120+
});
111121
expect(renderer.toJSON()).toEqual({
112122
type: 'div',
113123
props: {},
@@ -155,7 +165,12 @@ describe('React hooks DevTools integration', () => {
155165
return <div>count:{count}</div>;
156166
}
157167

158-
const renderer = ReactTestRenderer.create(<MyComponent />);
168+
let renderer;
169+
await act(() => {
170+
renderer = ReactTestRenderer.create(<MyComponent />, {
171+
unstable_isConcurrent: true,
172+
});
173+
});
159174
expect(renderer.toJSON()).toEqual({
160175
type: 'div',
161176
props: {},
@@ -192,14 +207,17 @@ describe('React hooks DevTools integration', () => {
192207
function MyComponent() {
193208
return 'Done';
194209
}
195-
196-
const renderer = ReactTestRenderer.create(
197-
<div>
198-
<React.Suspense fallback={'Loading'}>
199-
<MyComponent />
200-
</React.Suspense>
201-
</div>,
202-
);
210+
let renderer;
211+
await act(() => {
212+
renderer = ReactTestRenderer.create(
213+
<div>
214+
<React.Suspense fallback={'Loading'}>
215+
<MyComponent />
216+
</React.Suspense>
217+
</div>,
218+
{unstable_isConcurrent: true},
219+
);
220+
});
203221
const fiber = renderer.root._currentFiber().child;
204222
if (__DEV__) {
205223
// First render was locked
@@ -236,7 +254,6 @@ describe('React hooks DevTools integration', () => {
236254
}
237255
});
238256

239-
// @gate __DEV__
240257
it('should support overriding suspense in concurrent mode', async () => {
241258
if (__DEV__) {
242259
// Lock the first render
@@ -254,7 +271,7 @@ describe('React hooks DevTools integration', () => {
254271
<MyComponent />
255272
</React.Suspense>
256273
</div>,
257-
{isConcurrent: true},
274+
{unstable_isConcurrent: true},
258275
),
259276
);
260277

0 commit comments

Comments
 (0)