Skip to content

Commit 543f520

Browse files
committed
Simplify fixture a bit to easier show usage with or without esm
1 parent 07cf810 commit 543f520

File tree

6 files changed

+19
-44
lines changed

6 files changed

+19
-44
lines changed

fixtures/flight/server/loader.mjs renamed to fixtures/flight/loader/index.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
import {
2-
resolve,
3-
getSource,
4-
} from 'react-transport-dom-webpack/node-loader';
1+
import {resolve, getSource} from 'react-transport-dom-webpack/node-loader';
52

63
export {resolve, getSource};
74

@@ -19,10 +16,7 @@ const babelOptions = {
1916
export async function transformSource(source, context, defaultTransformSource) {
2017
const {format} = context;
2118
if (format === 'module') {
22-
const opt = Object.assign(
23-
{filename: context.url},
24-
babelOptions
25-
);
19+
const opt = Object.assign({filename: context.url}, babelOptions);
2620
const {code} = await babel.transformAsync(source, opt);
2721
return {source: code};
2822
}

fixtures/flight/loader/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"type": "module"
3+
}

fixtures/flight/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
"prebuild": "cp -r ../../build/node_modules/* ./node_modules/",
6868
"start": "concurrently \"npm run start:server\" \"npm run start:client\"",
6969
"start:client": "node scripts/start.js",
70-
"start:server": "NODE_ENV=development node --experimental-loader ./server/loader.mjs server",
70+
"start:server": "NODE_ENV=development node --experimental-loader ./loader/index.js server",
7171
"start:prod": "node scripts/build.js && NODE_ENV=production node server",
7272
"build": "node scripts/build.js",
7373
"test": "node scripts/test.js --env=jsdom"

fixtures/flight/server/handler.server.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,26 @@
22

33
import {pipeToNodeWritable} from 'react-transport-dom-webpack/server';
44
import * as React from 'react';
5-
import App from '../src/App.server';
65

7-
module.exports = function(req, res) {
6+
import url from 'url';
7+
8+
function resolve(path) {
9+
return url.pathToFileURL(require.resolve(path)).href;
10+
}
11+
12+
module.exports = async function(req, res) {
813
res.setHeader('Access-Control-Allow-Origin', '*');
14+
const m = await import('../src/App.server.js');
15+
// const m = require('../src/App.server.js');
16+
const App = m.default.default || m.default;
917
pipeToNodeWritable(<App />, res, {
1018
// TODO: Read from a map on the disk.
11-
[require.resolve('../src/Counter.client.js')]: {
19+
[resolve('../src/Counter.client.js')]: {
1220
id: './src/Counter.client.js',
1321
chunks: ['1'],
1422
name: 'default',
1523
},
16-
[require.resolve('../src/ShowMore.client.js')]: {
24+
[resolve('../src/ShowMore.client.js')]: {
1725
id: './src/ShowMore.client.js',
1826
chunks: ['2'],
1927
name: 'default',

fixtures/flight/server/handler.server.mjs

Lines changed: 0 additions & 29 deletions
This file was deleted.

fixtures/flight/server/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ app.get('/', function(req, res) {
2121
delete require.cache[key];
2222
}
2323
}
24-
import('./handler.server.mjs').then(m => m.default(req, res));
25-
// require('./handler.server.js')(req, res);
24+
require('./handler.server.js')(req, res);
2625
});
2726

2827
app.listen(3001, () => {

0 commit comments

Comments
 (0)