Skip to content

Commit 4bd31b2

Browse files
committed
[Flight] Add findSourceMapURL option to get a URL to load Server source maps from (#29708)
This lets you click a stack frame on the client and see the Server source code inline. <img width="871" alt="Screenshot 2024-06-01 at 11 44 24 PM" src="https://github.com/facebook/react/assets/63648/581281ce-0dce-40c0-a084-4a6d53ba1682"> <img width="840" alt="Screenshot 2024-06-01 at 11 43 37 PM" src="https://github.com/facebook/react/assets/63648/00dc77af-07c1-4389-9ae0-cf1f45199efb"> We could do some logic on the server that sends a source map url for every stack frame in the RSC payload. That would make the client potentially config free. However regardless we need the config to describe what url scheme to use since that’s not built in to the bundler config. In practice you likely have a common pattern for your source maps so no need to send data over and over when we can just have a simple function configured on the client. The server must return a source map, even if the file is not actually compiled since the fake file is still compiled. The source mapping strategy can be one of two models depending on if the server’s stack traces (`new Error().stack`) are source mapped back to the original (`—enable-source-maps`) or represents the location in compiled code (like in the browser). If it represents the location in compiled code it’s actually easier. You just serve the source map generated for that file by the tooling. If it is already source mapped it has to generate a source map where everything points to the same location (as if not compiled) ideally with a segment per logical ast node. DiffTrain build for commit ba099e4.
1 parent 9e1cf0f commit 4bd31b2

File tree

13 files changed

+35
-35
lines changed

13 files changed

+35
-35
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4887615a72d26b2ab91dc87285867a37>>
10+
* @generated SignedSource<<e46c259f77c707213400911161b76127>>
1111
*/
1212

1313
'use strict';
@@ -23495,7 +23495,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2349523495
return root;
2349623496
}
2349723497

23498-
var ReactVersion = '19.0.0-rc-d77dd31a32-20240601';
23498+
var ReactVersion = '19.0.0-rc-ba099e442b-20240602';
2349923499

2350023500
/*
2350123501
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<961ae6d712bb58a1b013d54b624b3cb4>>
10+
* @generated SignedSource<<3dc0798cc15fe2c5c351df969cb8ee38>>
1111
*/
1212

1313
"use strict";
@@ -9303,7 +9303,7 @@ var devToolsConfig$jscomp$inline_1047 = {
93039303
throw Error("TestRenderer does not support findFiberByHostInstance()");
93049304
},
93059305
bundleType: 0,
9306-
version: "19.0.0-rc-d77dd31a32-20240601",
9306+
version: "19.0.0-rc-ba099e442b-20240602",
93079307
rendererPackageName: "react-test-renderer"
93089308
};
93099309
var internals$jscomp$inline_1234 = {
@@ -9334,7 +9334,7 @@ var internals$jscomp$inline_1234 = {
93349334
scheduleRoot: null,
93359335
setRefreshHandler: null,
93369336
getCurrentFiber: null,
9337-
reconcilerVersion: "19.0.0-rc-d77dd31a32-20240601"
9337+
reconcilerVersion: "19.0.0-rc-ba099e442b-20240602"
93389338
};
93399339
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
93409340
var hook$jscomp$inline_1235 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d463a63e15824a8f6b8b287dee8a372a>>
10+
* @generated SignedSource<<21eeadb2c56189bfb606330b53a5ea24>>
1111
*/
1212

1313
"use strict";
@@ -9925,7 +9925,7 @@ var devToolsConfig$jscomp$inline_1130 = {
99259925
throw Error("TestRenderer does not support findFiberByHostInstance()");
99269926
},
99279927
bundleType: 0,
9928-
version: "19.0.0-rc-d77dd31a32-20240601",
9928+
version: "19.0.0-rc-ba099e442b-20240602",
99299929
rendererPackageName: "react-test-renderer"
99309930
};
99319931
(function (internals) {
@@ -9969,7 +9969,7 @@ var devToolsConfig$jscomp$inline_1130 = {
99699969
scheduleRoot: null,
99709970
setRefreshHandler: null,
99719971
getCurrentFiber: null,
9972-
reconcilerVersion: "19.0.0-rc-d77dd31a32-20240601"
9972+
reconcilerVersion: "19.0.0-rc-ba099e442b-20240602"
99739973
});
99749974
exports._Scheduler = Scheduler;
99759975
exports.act = act;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<757cbdc8d177c7ce024d9bc5ee918224>>
10+
* @generated SignedSource<<0b985823c75d0e9f984cd707c556bb1a>>
1111
*/
1212

1313
'use strict';
@@ -24,7 +24,7 @@ if (
2424
}
2525
var dynamicFlagsUntyped = require('ReactNativeInternalFeatureFlags');
2626

27-
var ReactVersion = '19.0.0-rc-d77dd31a32-20240601';
27+
var ReactVersion = '19.0.0-rc-ba099e442b-20240602';
2828

2929
// Re-export dynamic flags from the internal module.
3030
var dynamicFlags = dynamicFlagsUntyped; // We destructure each value before re-exporting to avoid a dynamic look-up on

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<3cba2f7b79c244ffaff592fb8654dea7>>
10+
* @generated SignedSource<<8ccc51eb81e3b432f0e4e3d079147b26>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-rc-d77dd31a32-20240601";
607+
exports.version = "19.0.0-rc-ba099e442b-20240602";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f1acb2f6346084960a5968e814e7a17d>>
10+
* @generated SignedSource<<a6b9fd38b06bf79490d7c0f665b609f8>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-rc-d77dd31a32-20240601";
611+
exports.version = "19.0.0-rc-ba099e442b-20240602";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d77dd31a329df55a051800fc76668af8da8332b4
1+
ba099e442b602b9414693dab9cfa67e19051037c

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<dcd1d94698ce06a0fff69539f6fd365f>>
10+
* @generated SignedSource<<a9e2752327671f030ac3edaf31aa5ef6>>
1111
*/
1212

1313
'use strict';
@@ -26230,7 +26230,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2623026230
return root;
2623126231
}
2623226232

26233-
var ReactVersion = '19.0.0-rc-d77dd31a32-20240601';
26233+
var ReactVersion = '19.0.0-rc-ba099e442b-20240602';
2623426234

2623526235
/*
2623626236
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<94da57c8d5864ea56eb9fa3830971408>>
10+
* @generated SignedSource<<c3b6bd52edfdebef5406ad3289463016>>
1111
*/
1212

1313
"use strict";
@@ -10556,7 +10556,7 @@ var roots = new Map(),
1055610556
devToolsConfig$jscomp$inline_1124 = {
1055710557
findFiberByHostInstance: getInstanceFromNode,
1055810558
bundleType: 0,
10559-
version: "19.0.0-rc-d77dd31a32-20240601",
10559+
version: "19.0.0-rc-ba099e442b-20240602",
1056010560
rendererPackageName: "react-native-renderer",
1056110561
rendererConfig: {
1056210562
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10599,7 +10599,7 @@ var internals$jscomp$inline_1350 = {
1059910599
scheduleRoot: null,
1060010600
setRefreshHandler: null,
1060110601
getCurrentFiber: null,
10602-
reconcilerVersion: "19.0.0-rc-d77dd31a32-20240601"
10602+
reconcilerVersion: "19.0.0-rc-ba099e442b-20240602"
1060310603
};
1060410604
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1060510605
var hook$jscomp$inline_1351 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5b3019b9ccba2039645f5e61548d4e3b>>
10+
* @generated SignedSource<<5f60751f65cf9ffd4771f3b327d7facd>>
1111
*/
1212

1313
"use strict";
@@ -11262,7 +11262,7 @@ var roots = new Map(),
1126211262
devToolsConfig$jscomp$inline_1205 = {
1126311263
findFiberByHostInstance: getInstanceFromNode,
1126411264
bundleType: 0,
11265-
version: "19.0.0-rc-d77dd31a32-20240601",
11265+
version: "19.0.0-rc-ba099e442b-20240602",
1126611266
rendererPackageName: "react-native-renderer",
1126711267
rendererConfig: {
1126811268
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11318,7 +11318,7 @@ var roots = new Map(),
1131811318
scheduleRoot: null,
1131911319
setRefreshHandler: null,
1132011320
getCurrentFiber: null,
11321-
reconcilerVersion: "19.0.0-rc-d77dd31a32-20240601"
11321+
reconcilerVersion: "19.0.0-rc-ba099e442b-20240602"
1132211322
});
1132311323
exports.createPortal = function (children, containerTag) {
1132411324
return createPortal$1(

0 commit comments

Comments
 (0)