Skip to content

Commit 4469700

Browse files
authored
Change ReactVersion from CJS to ES module (#18181)
1 parent 58eedbb commit 4469700

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

packages/shared/ReactVersion.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
'use strict';
9-
108
// TODO: this is special because it gets imported during build.
11-
module.exports = '16.13.0';
9+
export default '16.13.0';

scripts/release/publish-commands/update-stable-version-numbers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const run = async ({cwd, packages, skipPackages, tags}) => {
4444
const sourceReactVersion = readFileSync(
4545
sourceReactVersionPath,
4646
'utf8'
47-
).replace(/module\.exports = '[^']+';/, `module.exports = '${version}';`);
47+
).replace(/export default '[^']+';/, `export default '${version}';`);
4848
writeFileSync(sourceReactVersionPath, sourceReactVersion);
4949
}
5050
};

scripts/release/utils.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,7 @@ const updateVersionsForNext = async (cwd, reactVersion, version) => {
209209
const sourceReactVersion = readFileSync(
210210
sourceReactVersionPath,
211211
'utf8'
212-
).replace(
213-
/module\.exports = '[^']+';/,
214-
`module.exports = '${reactVersion}';`
215-
);
212+
).replace(/export default '[^']+';/, `export default '${reactVersion}';`);
216213
writeFileSync(sourceReactVersionPath, sourceReactVersion);
217214

218215
// Update the root package.json.

scripts/tasks/version-check.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,20 @@
77

88
'use strict';
99

10-
const reactVersion = require('../../package.json').version;
10+
const fs = require('fs');
11+
const ReactVersionSrc = fs.readFileSync(
12+
require.resolve('../../packages/shared/ReactVersion')
13+
);
14+
const reactVersion = /export default '([^']+)';/.exec(ReactVersionSrc)[1];
15+
1116
const versions = {
1217
'packages/react/package.json': require('../../packages/react/package.json')
1318
.version,
1419
'packages/react-dom/package.json': require('../../packages/react-dom/package.json')
1520
.version,
1621
'packages/react-test-renderer/package.json': require('../../packages/react-test-renderer/package.json')
1722
.version,
18-
'packages/shared/ReactVersion.js': require('../../packages/shared/ReactVersion'),
23+
'packages/shared/ReactVersion.js': reactVersion,
1924
};
2025

2126
let allVersionsMatch = true;

0 commit comments

Comments
 (0)