[ci] Cleanup

poteto · poteto · commit 417d6f5282c7 · 2024-06-22T12:33:39.000-04:00
- Made each workflow's name consistent - Rename each workflow file with consistent naming scheme - Promote flow-ci-ghaction to flow-ci ghstack-source-id: 490b643 Pull Request resolved: #30037
diff --git a/.github/workflows/compiler_playground.yml b/.github/workflows/compiler_playground.yml
@@ -1,4 +1,4 @@
-name: Compiler Playground
+name: (Compiler) Playground
 
 on:
   push:
diff --git a/.github/workflows/compiler_rust.yml b/.github/workflows/compiler_rust.yml
@@ -1,4 +1,4 @@
-name: React Compiler (Rust)
+name: (Compiler) Rust
 
 on:
   push:
diff --git a/.github/workflows/compiler_typescript.yml b/.github/workflows/compiler_typescript.yml
@@ -1,4 +1,4 @@
-name: React Compiler (TypeScript)
+name: (Compiler) TypeScript
 
 on:
   push:
diff --git a/.github/workflows/devtools_check_repro.yml b/.github/workflows/devtools_check_repro.yml
@@ -1,4 +1,4 @@
-name: DevTools Check for bug repro
+name: (DevTools) Check for bug repro
 on:
   issues:
     types: [opened, edited]
diff --git a/.github/workflows/runtime_commit_artifacts.yml b/.github/workflows/runtime_commit_artifacts.yml
@@ -1,4 +1,4 @@
-name: Commit Artifacts for Meta WWW and fbsource
+name: (Runtime) Commit Artifacts for Meta WWW and fbsource
 
 on:
   push:
diff --git a/.github/workflows/runtime_fizz.yml b/.github/workflows/runtime_fizz.yml
@@ -1,4 +1,4 @@
-name: Fizz
+name: (Runtime) Fizz
 
 on:
   push:
diff --git a/.github/workflows/runtime_flags.yml b/.github/workflows/runtime_flags.yml
@@ -1,4 +1,4 @@
-name: Flags
+name: (Runtime) Flags
 
 on:
   push:
diff --git a/.github/workflows/runtime_flow.yml b/.github/workflows/runtime_flow.yml
@@ -1,4 +1,4 @@
-name: Flow
+name: (Runtime) Flow
 
 on:
   push:
@@ -44,4 +44,4 @@ jobs:
           path: "**/node_modules"
           key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
       - run: yarn install --frozen-lockfile
-      - run: node ./scripts/tasks/flow-ci-ghaction ${{ matrix.flow_inline_config_shortname }}
+      - run: node ./scripts/tasks/flow-ci ${{ matrix.flow_inline_config_shortname }}
diff --git a/.github/workflows/runtime_fuzz_tests.yml b/.github/workflows/runtime_fuzz_tests.yml
@@ -1,4 +1,4 @@
-name: facebook/react/fuzz_tests
+name: (Runtime) Fuzz tests
 on:
   schedule:
   - cron: 0 * * * *
diff --git a/.github/workflows/runtime_test.yml b/.github/workflows/runtime_test.yml
@@ -1,4 +1,4 @@
-name: React Runtime (Test)
+name: (Runtime) Test
 
 on:
   push:
diff --git a/.github/workflows/shared_lint.yml b/.github/workflows/shared_lint.yml
@@ -1,4 +1,4 @@
-name: Lint
+name: (Shared) Lint
 
 on:
   push:
diff --git a/.github/workflows/shared_stale.yml b/.github/workflows/shared_stale.yml
@@ -1,5 +1,5 @@
 # Configuration for stale action workflow - https://github.com/actions/stale
-name: 'Manage stale issues and PRs'
+name: (Shared) Manage stale issues and PRs
 on:
   schedule:
     # Run hourly
diff --git a/scripts/tasks/flow-ci-ghaction.js b/scripts/tasks/flow-ci-ghaction.js
diff --git a/scripts/tasks/flow-ci.js b/scripts/tasks/flow-ci.js
@@ -14,24 +14,19 @@ process.on('unhandledRejection', err => {
 const runFlow = require('../flow/runFlow');
 const inlinedHostConfigs = require('../shared/inlinedHostConfigs');
 
-// Parallelize tests across multiple tasks.
-const nodeTotal = process.env.CIRCLE_NODE_TOTAL
-  ? parseInt(process.env.CIRCLE_NODE_TOTAL, 10)
-  : 1;
-const nodeIndex = process.env.CIRCLE_NODE_INDEX
-  ? parseInt(process.env.CIRCLE_NODE_INDEX, 10)
-  : 0;
-
-async function checkAll() {
-  for (let i = 0; i < inlinedHostConfigs.length; i++) {
-    if (i % nodeTotal === nodeIndex) {
-      const rendererInfo = inlinedHostConfigs[i];
-      if (rendererInfo.isFlowTyped) {
-        await runFlow(rendererInfo.shortName, ['check']);
-        console.log();
-      }
-    }
+async function check(shortName) {
+  if (shortName == null) {
+    throw new Error('Expected an inlinedHostConfig shortName');
+  }
+  const rendererInfo = inlinedHostConfigs.find(
+    config => config.shortName === shortName
+  );
+  if (rendererInfo == null) {
+    throw new Error(`Could not find inlinedHostConfig for ${shortName}`);
+  }
+  if (rendererInfo.isFlowTyped) {
+    await runFlow(rendererInfo.shortName, ['check']);
   }
 }
 
-checkAll();
+check(process.argv[2]);

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Compiler Playground`
	`1`	`+name: (Compiler) Playground`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: React Compiler (Rust)`
	`1`	`+name: (Compiler) Rust`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: React Compiler (TypeScript)`
	`1`	`+name: (Compiler) TypeScript`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: DevTools Check for bug repro`
	`1`	`+name: (DevTools) Check for bug repro`
`2`	`2`	`on:`
`3`	`3`	`issues:`
`4`	`4`	`types: [opened, edited]`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Commit Artifacts for Meta WWW and fbsource`
	`1`	`+name: (Runtime) Commit Artifacts for Meta WWW and fbsource`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Fizz`
	`1`	`+name: (Runtime) Fizz`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Flags`
	`1`	`+name: (Runtime) Flags`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: facebook/react/fuzz_tests`
	`1`	`+name: (Runtime) Fuzz tests`
`2`	`2`	`on:`
`3`	`3`	`schedule:`
`4`	`4`	`- cron: 0 * * * *`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: React Runtime (Test)`
	`1`	`+name: (Runtime) Test`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`