Skip to content

Commit 3b068f6

Browse files
jbrown215jbrown215
committed
[compiler] Do not inline IIFEs in value blocks (#33548)
As discussed in chat, this is a simple fix to stop introducing labels inside expressions. The useMemo-with-optional test was added in d70b2c2 and crashes for the same reason- an unexpected label as a value block terminal. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33548). * __->__ #33548 * #33546 DiffTrain build for [90bee81](90bee81)
1 parent 126148e commit 3b068f6

26 files changed

+201
-197
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-5d24c64c-20250616
1+
19.2.0-native-fb-90bee819-20250616

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ae0259d212948d5f1b91865278031c0d>>
10+
* @generated SignedSource<<e91cacbbd25ef5ec3704e92e4f05e818>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
407+
exports.version = "19.2.0-native-fb-90bee819-20250616";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7e4ee29c33aff51a9a8dadef95d5e058>>
10+
* @generated SignedSource<<c8f91d5fbb90d1da0bfa1bfe1c6bd800>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
206+
exports.version = "19.2.0-native-fb-90bee819-20250616";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7e4ee29c33aff51a9a8dadef95d5e058>>
10+
* @generated SignedSource<<c8f91d5fbb90d1da0bfa1bfe1c6bd800>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
206+
exports.version = "19.2.0-native-fb-90bee819-20250616";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<3a0f2c20f438fe403c4fc908990e680a>>
10+
* @generated SignedSource<<264da4cf0077e039079b0dba5b9855b6>>
1111
*/
1212

1313
/*
@@ -27061,11 +27061,11 @@ __DEV__ &&
2706127061
};
2706227062
(function () {
2706327063
var isomorphicReactPackageVersion = React.version;
27064-
if ("19.2.0-native-fb-5d24c64c-20250616" !== isomorphicReactPackageVersion)
27064+
if ("19.2.0-native-fb-90bee819-20250616" !== isomorphicReactPackageVersion)
2706527065
throw Error(
2706627066
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2706727067
(isomorphicReactPackageVersion +
27068-
"\n - react-dom: 19.2.0-native-fb-5d24c64c-20250616\nLearn more: https://react.dev/warnings/version-mismatch")
27068+
"\n - react-dom: 19.2.0-native-fb-90bee819-20250616\nLearn more: https://react.dev/warnings/version-mismatch")
2706927069
);
2707027070
})();
2707127071
("function" === typeof Map &&
@@ -27102,10 +27102,10 @@ __DEV__ &&
2710227102
!(function () {
2710327103
var internals = {
2710427104
bundleType: 1,
27105-
version: "19.2.0-native-fb-5d24c64c-20250616",
27105+
version: "19.2.0-native-fb-90bee819-20250616",
2710627106
rendererPackageName: "react-dom",
2710727107
currentDispatcherRef: ReactSharedInternals,
27108-
reconcilerVersion: "19.2.0-native-fb-5d24c64c-20250616"
27108+
reconcilerVersion: "19.2.0-native-fb-90bee819-20250616"
2710927109
};
2711027110
internals.overrideHookState = overrideHookState;
2711127111
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27243,5 +27243,5 @@ __DEV__ &&
2724327243
listenToAllSupportedEvents(container);
2724427244
return new ReactDOMHydrationRoot(initialChildren);
2724527245
};
27246-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
27246+
exports.version = "19.2.0-native-fb-90bee819-20250616";
2724727247
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<428e26a94ee562ef7f13a4f3f4132a44>>
10+
* @generated SignedSource<<b382829c48457d999d45010f7474d428>>
1111
*/
1212

1313
/*
@@ -17118,14 +17118,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1711817118
};
1711917119
var isomorphicReactPackageVersion$jscomp$inline_2017 = React.version;
1712017120
if (
17121-
"19.2.0-native-fb-5d24c64c-20250616" !==
17121+
"19.2.0-native-fb-90bee819-20250616" !==
1712217122
isomorphicReactPackageVersion$jscomp$inline_2017
1712317123
)
1712417124
throw Error(
1712517125
formatProdErrorMessage(
1712617126
527,
1712717127
isomorphicReactPackageVersion$jscomp$inline_2017,
17128-
"19.2.0-native-fb-5d24c64c-20250616"
17128+
"19.2.0-native-fb-90bee819-20250616"
1712917129
)
1713017130
);
1713117131
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17147,10 +17147,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1714717147
};
1714817148
var internals$jscomp$inline_2536 = {
1714917149
bundleType: 0,
17150-
version: "19.2.0-native-fb-5d24c64c-20250616",
17150+
version: "19.2.0-native-fb-90bee819-20250616",
1715117151
rendererPackageName: "react-dom",
1715217152
currentDispatcherRef: ReactSharedInternals,
17153-
reconcilerVersion: "19.2.0-native-fb-5d24c64c-20250616"
17153+
reconcilerVersion: "19.2.0-native-fb-90bee819-20250616"
1715417154
};
1715517155
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1715617156
var hook$jscomp$inline_2537 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17248,4 +17248,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1724817248
listenToAllSupportedEvents(container);
1724917249
return new ReactDOMHydrationRoot(initialChildren);
1725017250
};
17251-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
17251+
exports.version = "19.2.0-native-fb-90bee819-20250616";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7ad3e4fc8e68b2153049e276e677e751>>
10+
* @generated SignedSource<<4079ebdc4d227c938a62849a7904f159>>
1111
*/
1212

1313
/*
@@ -17828,14 +17828,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1782817828
};
1782917829
var isomorphicReactPackageVersion$jscomp$inline_2120 = React.version;
1783017830
if (
17831-
"19.2.0-native-fb-5d24c64c-20250616" !==
17831+
"19.2.0-native-fb-90bee819-20250616" !==
1783217832
isomorphicReactPackageVersion$jscomp$inline_2120
1783317833
)
1783417834
throw Error(
1783517835
formatProdErrorMessage(
1783617836
527,
1783717837
isomorphicReactPackageVersion$jscomp$inline_2120,
17838-
"19.2.0-native-fb-5d24c64c-20250616"
17838+
"19.2.0-native-fb-90bee819-20250616"
1783917839
)
1784017840
);
1784117841
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17857,10 +17857,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1785717857
};
1785817858
var internals$jscomp$inline_2127 = {
1785917859
bundleType: 0,
17860-
version: "19.2.0-native-fb-5d24c64c-20250616",
17860+
version: "19.2.0-native-fb-90bee819-20250616",
1786117861
rendererPackageName: "react-dom",
1786217862
currentDispatcherRef: ReactSharedInternals,
17863-
reconcilerVersion: "19.2.0-native-fb-5d24c64c-20250616",
17863+
reconcilerVersion: "19.2.0-native-fb-90bee819-20250616",
1786417864
getLaneLabelMap: function () {
1786517865
for (
1786617866
var map = new Map(), lane = 1, index$313 = 0;
@@ -17973,4 +17973,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1797317973
listenToAllSupportedEvents(container);
1797417974
return new ReactDOMHydrationRoot(initialChildren);
1797517975
};
17976-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
17976+
exports.version = "19.2.0-native-fb-90bee819-20250616";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9a5e48f726be1ec4aee30959b1f18bdf>>
10+
* @generated SignedSource<<5747f93efd2f4cf88b4f0abbd46ca834>>
1111
*/
1212

1313
/*
@@ -27117,11 +27117,11 @@ __DEV__ &&
2711727117
};
2711827118
(function () {
2711927119
var isomorphicReactPackageVersion = React.version;
27120-
if ("19.2.0-native-fb-5d24c64c-20250616" !== isomorphicReactPackageVersion)
27120+
if ("19.2.0-native-fb-90bee819-20250616" !== isomorphicReactPackageVersion)
2712127121
throw Error(
2712227122
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2712327123
(isomorphicReactPackageVersion +
27124-
"\n - react-dom: 19.2.0-native-fb-5d24c64c-20250616\nLearn more: https://react.dev/warnings/version-mismatch")
27124+
"\n - react-dom: 19.2.0-native-fb-90bee819-20250616\nLearn more: https://react.dev/warnings/version-mismatch")
2712527125
);
2712627126
})();
2712727127
("function" === typeof Map &&
@@ -27158,10 +27158,10 @@ __DEV__ &&
2715827158
!(function () {
2715927159
var internals = {
2716027160
bundleType: 1,
27161-
version: "19.2.0-native-fb-5d24c64c-20250616",
27161+
version: "19.2.0-native-fb-90bee819-20250616",
2716227162
rendererPackageName: "react-dom",
2716327163
currentDispatcherRef: ReactSharedInternals,
27164-
reconcilerVersion: "19.2.0-native-fb-5d24c64c-20250616"
27164+
reconcilerVersion: "19.2.0-native-fb-90bee819-20250616"
2716527165
};
2716627166
internals.overrideHookState = overrideHookState;
2716727167
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27615,7 +27615,7 @@ __DEV__ &&
2761527615
exports.useFormStatus = function () {
2761627616
return resolveDispatcher().useHostTransitionStatus();
2761727617
};
27618-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
27618+
exports.version = "19.2.0-native-fb-90bee819-20250616";
2761927619
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2762027620
"function" ===
2762127621
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9cf8c4a8e38a22346c311b891518dd39>>
10+
* @generated SignedSource<<8a5c1a7a6b98308ae029e55ae4d40a89>>
1111
*/
1212

1313
/*
@@ -17129,14 +17129,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712917129
};
1713017130
var isomorphicReactPackageVersion$jscomp$inline_2018 = React.version;
1713117131
if (
17132-
"19.2.0-native-fb-5d24c64c-20250616" !==
17132+
"19.2.0-native-fb-90bee819-20250616" !==
1713317133
isomorphicReactPackageVersion$jscomp$inline_2018
1713417134
)
1713517135
throw Error(
1713617136
formatProdErrorMessage(
1713717137
527,
1713817138
isomorphicReactPackageVersion$jscomp$inline_2018,
17139-
"19.2.0-native-fb-5d24c64c-20250616"
17139+
"19.2.0-native-fb-90bee819-20250616"
1714017140
)
1714117141
);
1714217142
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17158,10 +17158,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715817158
};
1715917159
var internals$jscomp$inline_2539 = {
1716017160
bundleType: 0,
17161-
version: "19.2.0-native-fb-5d24c64c-20250616",
17161+
version: "19.2.0-native-fb-90bee819-20250616",
1716217162
rendererPackageName: "react-dom",
1716317163
currentDispatcherRef: ReactSharedInternals,
17164-
reconcilerVersion: "19.2.0-native-fb-5d24c64c-20250616"
17164+
reconcilerVersion: "19.2.0-native-fb-90bee819-20250616"
1716517165
};
1716617166
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1716717167
var hook$jscomp$inline_2540 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17412,4 +17412,4 @@ exports.useFormState = function (action, initialState, permalink) {
1741217412
exports.useFormStatus = function () {
1741317413
return ReactSharedInternals.H.useHostTransitionStatus();
1741417414
};
17415-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
17415+
exports.version = "19.2.0-native-fb-90bee819-20250616";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e6007e6ef29ff5699e84b14b40f32107>>
10+
* @generated SignedSource<<23c3c08ad5df710086586a20e27468d3>>
1111
*/
1212

1313
/*
@@ -17843,14 +17843,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1784317843
};
1784417844
var isomorphicReactPackageVersion$jscomp$inline_2121 = React.version;
1784517845
if (
17846-
"19.2.0-native-fb-5d24c64c-20250616" !==
17846+
"19.2.0-native-fb-90bee819-20250616" !==
1784717847
isomorphicReactPackageVersion$jscomp$inline_2121
1784817848
)
1784917849
throw Error(
1785017850
formatProdErrorMessage(
1785117851
527,
1785217852
isomorphicReactPackageVersion$jscomp$inline_2121,
17853-
"19.2.0-native-fb-5d24c64c-20250616"
17853+
"19.2.0-native-fb-90bee819-20250616"
1785417854
)
1785517855
);
1785617856
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17872,10 +17872,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1787217872
};
1787317873
var internals$jscomp$inline_2128 = {
1787417874
bundleType: 0,
17875-
version: "19.2.0-native-fb-5d24c64c-20250616",
17875+
version: "19.2.0-native-fb-90bee819-20250616",
1787617876
rendererPackageName: "react-dom",
1787717877
currentDispatcherRef: ReactSharedInternals,
17878-
reconcilerVersion: "19.2.0-native-fb-5d24c64c-20250616",
17878+
reconcilerVersion: "19.2.0-native-fb-90bee819-20250616",
1787917879
getLaneLabelMap: function () {
1788017880
for (
1788117881
var map = new Map(), lane = 1, index$313 = 0;
@@ -18141,7 +18141,7 @@ exports.useFormState = function (action, initialState, permalink) {
1814118141
exports.useFormStatus = function () {
1814218142
return ReactSharedInternals.H.useHostTransitionStatus();
1814318143
};
18144-
exports.version = "19.2.0-native-fb-5d24c64c-20250616";
18144+
exports.version = "19.2.0-native-fb-90bee819-20250616";
1814518145
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1814618146
"function" ===
1814718147
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)