[cleanup] remove old feature flag warnAboutDeprecatedLifecycles (#25978)

kassens · kassens · commit 2950351269a1 · 2023-01-10T20:38:56.000Z
This feature flag was always set to true, we can easily clean it up. DiffTrain build for [a48e54f](a48e54f) [View git log for this commit](https://github.com/facebook/react/commits/a48e54f2b74d87d90b0a3bff3a9b52fd9188308b)
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-0f4a83596646c610c06b751fc8ac0fc51f90d796
+a48e54f2b74d87d90b0a3bff3a9b52fd9188308b
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-0f4a83596646c610c06b751fc8ac0fc51f90d796
+a48e54f2b74d87d90b0a3bff3a9b52fd9188308b
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-classic-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-classic-a48e54f2b-20230110";
 
 // ATTENTION
 // When adding new symbols to this file,
diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-modern-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-modern-a48e54f2b-20230110";
 
 // ATTENTION
 // When adding new symbols to this file,
diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-0f4a83596-20230110";
+exports.version = "18.3.0-www-classic-a48e54f2b-20230110";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-0f4a83596-20230110";
+exports.version = "18.3.0-www-modern-a48e54f2b-20230110";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-0f4a83596-20230110";
+exports.version = "18.3.0-www-classic-a48e54f2b-20230110";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-0f4a83596-20230110";
+exports.version = "18.3.0-www-modern-a48e54f2b-20230110";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-classic-a48e54f2b-20230110";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -11646,12 +11646,10 @@ function mountClassInstance(workInProgress, ctor, newProps, renderLanes) {
       );
     }
 
-    {
-      ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
-        workInProgress,
-        instance
-      );
-    }
+    ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
+      workInProgress,
+      instance
+    );
   }
 
   instance.state = workInProgress.memoizedState;
@@ -25951,10 +25949,7 @@ function throwIfInfiniteUpdateLoopDetected() {
 function flushRenderPhaseStrictModeWarningsInDEV() {
   {
     ReactStrictModeWarnings.flushLegacyContextWarning();
-
-    {
-      ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
-    }
+    ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
   }
 }
 
diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-modern-a48e54f2b-20230110";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -11384,12 +11384,10 @@ function mountClassInstance(workInProgress, ctor, newProps, renderLanes) {
       );
     }
 
-    {
-      ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
-        workInProgress,
-        instance
-      );
-    }
+    ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
+      workInProgress,
+      instance
+    );
   }
 
   instance.state = workInProgress.memoizedState;
@@ -25640,10 +25638,7 @@ function throwIfInfiniteUpdateLoopDetected() {
 function flushRenderPhaseStrictModeWarningsInDEV() {
   {
     ReactStrictModeWarnings.flushLegacyContextWarning();
-
-    {
-      ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
-    }
+    ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
   }
 }
 
diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -9804,7 +9804,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-classic-0f4a83596-20230110",
+    version: "18.3.0-www-classic-a48e54f2b-20230110",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1318 = {
@@ -9835,7 +9835,7 @@ var internals$jscomp$inline_1318 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-0f4a83596-20230110"
+  reconcilerVersion: "18.3.0-next-a48e54f2b-20230110"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -9471,7 +9471,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-modern-0f4a83596-20230110",
+    version: "18.3.0-www-modern-a48e54f2b-20230110",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1309 = {
@@ -9502,7 +9502,7 @@ var internals$jscomp$inline_1309 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-0f4a83596-20230110"
+  reconcilerVersion: "18.3.0-next-a48e54f2b-20230110"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -25969,12 +25969,10 @@ function mountClassInstance(workInProgress, ctor, newProps, renderLanes) {
       );
     }
 
-    {
-      ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
-        workInProgress,
-        instance
-      );
-    }
+    ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
+      workInProgress,
+      instance
+    );
   }
 
   instance.state = workInProgress.memoizedState;
@@ -41008,10 +41006,7 @@ function throwIfInfiniteUpdateLoopDetected() {
 function flushRenderPhaseStrictModeWarningsInDEV() {
   {
     ReactStrictModeWarnings.flushLegacyContextWarning();
-
-    {
-      ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
-    }
+    ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
   }
 }
 
@@ -42702,7 +42697,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-classic-a48e54f2b-20230110";
 
 function createPortal(
   children,
diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -25742,12 +25742,10 @@ function mountClassInstance(workInProgress, ctor, newProps, renderLanes) {
       );
     }
 
-    {
-      ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
-        workInProgress,
-        instance
-      );
-    }
+    ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(
+      workInProgress,
+      instance
+    );
   }
 
   instance.state = workInProgress.memoizedState;
@@ -40732,10 +40730,7 @@ function throwIfInfiniteUpdateLoopDetected() {
 function flushRenderPhaseStrictModeWarningsInDEV() {
   {
     ReactStrictModeWarnings.flushLegacyContextWarning();
-
-    {
-      ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
-    }
+    ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();
   }
 }
 
@@ -42426,7 +42421,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-modern-a48e54f2b-20230110";
 
 function createPortal(
   children,
diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -15554,7 +15554,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1750 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-0f4a83596-20230110",
+  version: "18.3.0-www-classic-a48e54f2b-20230110",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2134 = {
@@ -15584,7 +15584,7 @@ var internals$jscomp$inline_2134 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-0f4a83596-20230110"
+  reconcilerVersion: "18.3.0-next-a48e54f2b-20230110"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2135 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15826,4 +15826,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-0f4a83596-20230110";
+exports.version = "18.3.0-next-a48e54f2b-20230110";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -15115,7 +15115,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1718 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-0f4a83596-20230110",
+  version: "18.3.0-www-modern-a48e54f2b-20230110",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2109 = {
@@ -15146,7 +15146,7 @@ var internals$jscomp$inline_2109 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-0f4a83596-20230110"
+  reconcilerVersion: "18.3.0-next-a48e54f2b-20230110"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15334,4 +15334,4 @@ exports.unstable_flushControlled = function(fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-0f4a83596-20230110";
+exports.version = "18.3.0-next-a48e54f2b-20230110";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -16324,7 +16324,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1824 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-0f4a83596-20230110",
+  version: "18.3.0-www-classic-a48e54f2b-20230110",
   rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -16368,7 +16368,7 @@ var devToolsConfig$jscomp$inline_1824 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-0f4a83596-20230110"
+  reconcilerVersion: "18.3.0-next-a48e54f2b-20230110"
 });
 assign(Internals, {
   ReactBrowserEventEmitter: {
@@ -16597,7 +16597,7 @@ exports.unstable_renderSubtreeIntoContainer = function(
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-0f4a83596-20230110";
+exports.version = "18.3.0-next-a48e54f2b-20230110";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -15875,7 +15875,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1792 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-0f4a83596-20230110",
+  version: "18.3.0-www-modern-a48e54f2b-20230110",
   rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -15920,7 +15920,7 @@ var devToolsConfig$jscomp$inline_1792 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-0f4a83596-20230110"
+  reconcilerVersion: "18.3.0-next-a48e54f2b-20230110"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function(children, container) {
@@ -16095,7 +16095,7 @@ exports.unstable_flushControlled = function(fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-0f4a83596-20230110";
+exports.version = "18.3.0-next-a48e54f2b-20230110";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-classic-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-classic-a48e54f2b-20230110";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-modern-0f4a83596-20230110";
+var ReactVersion = "18.3.0-www-modern-a48e54f2b-20230110";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js
@@ -3633,4 +3633,4 @@ exports.renderToString = function(children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-classic-0f4a83596-20230110";
+exports.version = "18.3.0-www-classic-a48e54f2b-20230110";
diff --git a/compiled/facebook-www/ReactDOMServer-prod.modern.js b/compiled/facebook-www/ReactDOMServer-prod.modern.js
@@ -3546,4 +3546,4 @@ exports.renderToString = function(children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-modern-0f4a83596-20230110";
+exports.version = "18.3.0-www-modern-a48e54f2b-20230110";
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js
diff --git a/compiled/facebook-www/ReactDOMTesting-prod.classic.js b/compiled/facebook-www/ReactDOMTesting-prod.classic.js
diff --git a/compiled/facebook-www/ReactDOMTesting-prod.modern.js b/compiled/facebook-www/ReactDOMTesting-prod.modern.js
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.classic.js b/compiled/facebook-www/ReactTestRenderer-dev.classic.js
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.modern.js b/compiled/facebook-www/ReactTestRenderer-dev.modern.js

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-0f4a83596646c610c06b751fc8ac0fc51f90d796`
	`1`	`+a48e54f2b74d87d90b0a3bff3a9b52fd9188308b`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ if (`
`27`	`27`	`}`
`28`	`28`	`"use strict";`
`29`	`29`
`30`		`-var ReactVersion = "18.3.0-www-classic-0f4a83596-20230110";`
	`30`	`+var ReactVersion = "18.3.0-www-classic-a48e54f2b-20230110";`
`31`	`31`
`32`	`32`	`// ATTENTION`
`33`	`33`	`// When adding new symbols to this file,`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {`
`69`	`69`	`return self;`
`70`	`70`	`}`
`71`	`71`
`72`		`-var ReactVersion = "18.3.0-www-classic-0f4a83596-20230110";`
	`72`	`+var ReactVersion = "18.3.0-www-classic-a48e54f2b-20230110";`
`73`	`73`
`74`	`74`	`var LegacyRoot = 0;`
`75`	`75`	`var ConcurrentRoot = 1;`
`@@ -11646,12 +11646,10 @@ function mountClassInstance(workInProgress, ctor, newProps, renderLanes) {`
`11646`	`11646`	`);`
`11647`	`11647`	`}`
`11648`	`11648`
`11649`		`- {`
`11650`		`- ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(`
`11651`		`- workInProgress,`
`11652`		`- instance`
`11653`		`- );`
`11654`		`- }`
	`11649`	`+ ReactStrictModeWarnings.recordUnsafeLifecycleWarnings(`
	`11650`	`+ workInProgress,`
	`11651`	`+ instance`
	`11652`	`+ );`
`11655`	`11653`	`}`
`11656`	`11654`
`11657`	`11655`	`instance.state = workInProgress.memoizedState;`
`@@ -25951,10 +25949,7 @@ function throwIfInfiniteUpdateLoopDetected() {`
`25951`	`25949`	`function flushRenderPhaseStrictModeWarningsInDEV() {`
`25952`	`25950`	`{`
`25953`	`25951`	`ReactStrictModeWarnings.flushLegacyContextWarning();`
`25954`		`-`
`25955`		`- {`
`25956`		`- ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();`
`25957`		`- }`
	`25952`	`+ ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings();`
`25958`	`25953`	`}`
`25959`	`25954`	`}`
`25960`	`25955`