Skip to content

Commit 240b84e

Browse files
authored
Remove PooledClass from isomorphic build (#10227)
* Inline traverseAllChildren into ReactChildren * Remove ForEachBookKeeping * Inline traversal pooling logic into ReactChildren * Reuse emptyFunction for dummy callback * Move code around * Record sizes
1 parent 9cf888f commit 240b84e

File tree

5 files changed

+251
-280
lines changed

5 files changed

+251
-280
lines changed

scripts/rollup/packaging.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const facebookWWWSrcDependencies = [
2424

2525
// these files need to be copied to the react-native build
2626
const reactNativeSrcDependencies = [
27-
'src/shared/utils/PooledClass.js',
27+
'src/renderers/shared/utils/PooledClass.js',
2828
'src/renderers/shared/fiber/isomorphic/ReactTypes.js',
2929
'src/renderers/native/ReactNativeTypes.js',
3030
];

scripts/rollup/results.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
{
22
"bundleSizes": {
33
"react.development.js (UMD_DEV)": {
4-
"size": 69376,
5-
"gzip": 17780
4+
"size": 65104,
5+
"gzip": 16679
66
},
77
"react.production.min.js (UMD_PROD)": {
8-
"size": 7585,
9-
"gzip": 3002
8+
"size": 6478,
9+
"gzip": 2700
1010
},
1111
"react.development.js (NODE_DEV)": {
12-
"size": 59667,
13-
"gzip": 15411
12+
"size": 55397,
13+
"gzip": 14325
1414
},
1515
"react.production.min.js (NODE_PROD)": {
16-
"size": 6451,
17-
"gzip": 2576
16+
"size": 5343,
17+
"gzip": 2268
1818
},
1919
"React-dev.js (FB_DEV)": {
20-
"size": 56905,
21-
"gzip": 14622
20+
"size": 52655,
21+
"gzip": 13543
2222
},
2323
"React-prod.js (FB_PROD)": {
24-
"size": 27099,
25-
"gzip": 7215
24+
"size": 24178,
25+
"gzip": 6601
2626
},
2727
"react-dom.development.js (UMD_DEV)": {
2828
"size": 624799,

0 commit comments

Comments
 (0)