Skip to content

Commit 1e5e9af

Browse files
committed
feedback: change Array.from(children) -> querySelectorAll
1 parent b5a3537 commit 1e5e9af

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/react-dom-bindings/src/server/ReactDOMServerExternalRuntime.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ if (document.body != null) {
5151
}
5252

5353
function handleExistingNodes(target /*: HTMLElement */) {
54-
const existingNodes = Array.from(target.children);
54+
const existingNodes = target.querySelectorAll('template');
5555
for (let i = 0; i < existingNodes.length; i++) {
5656
handleNode(existingNodes[i]);
5757
}
@@ -62,8 +62,8 @@ function installFizzInstrObserver(target /*: Node */) {
6262
for (let i = 0; i < mutations.length; i++) {
6363
const addedNodes = mutations[i].addedNodes;
6464
for (let j = 0; j < addedNodes.length; j++) {
65-
if (addedNodes.item(j).parentNode) {
66-
handleNode(addedNodes.item(j));
65+
if (addedNodes[j].parentNode) {
66+
handleNode(addedNodes[j]);
6767
}
6868
}
6969
}

0 commit comments

Comments
 (0)