Skip to content

Commit 0e80e1c

Browse files
committed
fix[devtools/tree/element]: onClick -> onMouseDown to handle first click correctly
1 parent 034130c commit 0e80e1c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

packages/react-devtools-inline/__tests__/__e2e__/devtools-utils.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ async function selectElement(page, displayName, waitForOwnersText) {
3737
createTestNameSelector('ComponentTreeListItem'),
3838
createTextSelector(listItemText),
3939
])[0];
40-
listItem.click();
40+
41+
listItem.dispatchEvent(
42+
new MouseEvent('mousedown', {bubbles: true, cancelable: true})
43+
);
4144
}, displayName);
4245

4346
if (waitForOwnersText) {

packages/react-devtools-shared/src/devtools/views/Components/Element.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export default function Element({data, index, style}: Props): React.Node {
142142
className={className}
143143
onMouseEnter={handleMouseEnter}
144144
onMouseLeave={handleMouseLeave}
145-
onClick={handleClick}
145+
onMouseDown={handleClick}
146146
onDoubleClick={handleDoubleClick}
147147
style={style}
148148
data-testname="ComponentTreeListItem"

0 commit comments

Comments
 (0)